mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-09 18:12:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Refs #33060 -- Ensured cache backends validate keys.

Browse source 
The validate_key() function should be called after make_key() to ensure
that the validation is performed on the key that will actually be
stored in the cache.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
Nick Pope 2021-09-03 11:26:27 +02:00 • committed by Mariusz Felisiak
parent ec2f6ea9c6
commit 4b82578a60
2 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/cache/tests.py vendored
View file

@ -675,7 +675,7 @@ class BaseCacheTests:
finally:
cull_cache._max_entries = old_max_entries
def _perform_invalid_key_test(self, key, expected_warning):
def _perform_invalid_key_test(self, key, expected_warning, key_func=None):
"""
All the builtin backends should warn (except memcached that should
error) on keys that would be refused by memcached. This encourages
@ -688,7 +688,7 @@ class BaseCacheTests:
return key
old_func = cache.key_func
cache.key_func = func
cache.key_func = key_func or func
tests = [
('add', [key, 1]),
@ -725,6 +725,19 @@ class BaseCacheTests:
)
self._perform_invalid_key_test(key, expected_warning)
def test_invalid_with_version_key_length(self):
# Custom make_key() that adds a version to the key and exceeds the
# limit.
def key_func(key, *args):
return key + ':1'
key = 'a' * 249
expected_warning = (
'Cache key will cause errors if used with memcached: '
'%r (longer than %s)' % (key_func(key), 250)
)
self._perform_invalid_key_test(key, expected_warning, key_func=key_func)
def test_cache_versioning_get_set(self):
# set, using default version = 1
cache.set('answer1', 42)