Fixed #26747 -- Used more specific assertions in the Django test suite.

This commit is contained in:
Jon Dufresne 2016-06-16 11:19:18 -07:00 committed by Tim Graham
parent ea34426ae7
commit 4f336f6652
87 changed files with 406 additions and 406 deletions

View file

@ -68,7 +68,7 @@ class TestSaveLoad(PostgreSQLTestCase):
instance = NullableIntegerArrayModel()
instance.save()
loaded = NullableIntegerArrayModel.objects.get(pk=instance.pk)
self.assertEqual(loaded.field, None)
self.assertIsNone(loaded.field)
self.assertEqual(instance.field, loaded.field)
def test_null_handling(self):

View file

@ -31,7 +31,7 @@ class SimpleTests(PostgreSQLTestCase):
instance = HStoreModel(field=None)
instance.save()
reloaded = HStoreModel.objects.get()
self.assertEqual(reloaded.field, None)
self.assertIsNone(reloaded.field)
def test_value_null(self):
value = {'a': None}

View file

@ -33,7 +33,7 @@ class TestSaveLoad(TestCase):
instance = JSONModel()
instance.save()
loaded = JSONModel.objects.get()
self.assertEqual(loaded.field, None)
self.assertIsNone(loaded.field)
def test_empty_object(self):
instance = JSONModel(field={})
@ -51,7 +51,7 @@ class TestSaveLoad(TestCase):
instance = JSONModel(field=True)
instance.save()
loaded = JSONModel.objects.get()
self.assertEqual(loaded.field, True)
self.assertIs(loaded.field, True)
def test_string(self):
instance = JSONModel(field='why?')
@ -247,7 +247,7 @@ class TestFormField(PostgreSQLTestCase):
def test_valid_empty(self):
field = forms.JSONField(required=False)
value = field.clean('')
self.assertEqual(value, None)
self.assertIsNone(value)
def test_invalid(self):
field = forms.JSONField()

View file

@ -58,7 +58,7 @@ class TestSaveLoad(PostgreSQLTestCase):
instance.save()
loaded = RangesModel.objects.get()
self.assertEqual(r, loaded.floats)
self.assertTrue(10 in loaded.floats)
self.assertIn(10, loaded.floats)
def test_unbounded(self):
r = NumericRange(None, None, '()')
@ -313,7 +313,7 @@ class TestSerialization(PostgreSQLTestCase):
instance = list(serializers.deserialize('json', self.test_data))[0].object
self.assertEqual(instance.ints, NumericRange(0, 10))
self.assertEqual(instance.floats, NumericRange(empty=True))
self.assertEqual(instance.bigints, None)
self.assertIsNone(instance.bigints)
self.assertEqual(instance.dates, DateRange(self.lower_date, self.upper_date))
self.assertEqual(instance.timestamps, DateTimeTZRange(self.lower_dt, self.upper_dt))
@ -409,7 +409,7 @@ class TestFormField(PostgreSQLTestCase):
def test_none(self):
field = pg_forms.IntegerRangeField(required=False)
value = field.clean(['', ''])
self.assertEqual(value, None)
self.assertIsNone(value)
def test_rendering(self):
class RangeForm(forms.Form):