mirror of
https://github.com/django/django.git
synced 2025-08-03 02:23:12 +00:00
[2.2.x] Fixed #30672 -- Fixed crash of JSONField/HStoreField key transforms on expressions with params.
Regression in4f5b58f5cd
. Thanks Florian Apolloner for the report and helping with tests. Backport of1f8382d34d
from master.
This commit is contained in:
parent
be4a2a0358
commit
52a7759a49
8 changed files with 68 additions and 3 deletions
|
@ -2,6 +2,7 @@ import json
|
|||
|
||||
from django.core import checks, exceptions, serializers
|
||||
from django.db import connection
|
||||
from django.db.models.expressions import RawSQL
|
||||
from django.forms import Form
|
||||
from django.test.utils import CaptureQueriesContext, isolate_apps
|
||||
|
||||
|
@ -11,6 +12,7 @@ from .models import HStoreModel, PostgreSQLModel
|
|||
try:
|
||||
from django.contrib.postgres import forms
|
||||
from django.contrib.postgres.fields import HStoreField
|
||||
from django.contrib.postgres.fields.hstore import KeyTransform
|
||||
from django.contrib.postgres.validators import KeysValidator
|
||||
except ImportError:
|
||||
pass
|
||||
|
@ -127,6 +129,13 @@ class TestQuerying(PostgreSQLTestCase):
|
|||
self.objs[:2]
|
||||
)
|
||||
|
||||
def test_key_transform_raw_expression(self):
|
||||
expr = RawSQL('%s::hstore', ['x => b, y => c'])
|
||||
self.assertSequenceEqual(
|
||||
HStoreModel.objects.filter(field__a=KeyTransform('x', expr)),
|
||||
self.objs[:2]
|
||||
)
|
||||
|
||||
def test_keys(self):
|
||||
self.assertSequenceEqual(
|
||||
HStoreModel.objects.filter(field__keys=['a']),
|
||||
|
|
|
@ -6,7 +6,9 @@ from decimal import Decimal
|
|||
from django.core import checks, exceptions, serializers
|
||||
from django.core.serializers.json import DjangoJSONEncoder
|
||||
from django.db import connection
|
||||
from django.db.models import Count, Q
|
||||
from django.db.models import Count, F, Q
|
||||
from django.db.models.expressions import RawSQL
|
||||
from django.db.models.functions import Cast
|
||||
from django.forms import CharField, Form, widgets
|
||||
from django.test.utils import CaptureQueriesContext, isolate_apps
|
||||
from django.utils.html import escape
|
||||
|
@ -177,6 +179,23 @@ class TestQuerying(PostgreSQLTestCase):
|
|||
operator.itemgetter('key', 'count'),
|
||||
)
|
||||
|
||||
def test_key_transform_raw_expression(self):
|
||||
expr = RawSQL('%s::jsonb', ['{"x": "bar"}'])
|
||||
self.assertSequenceEqual(
|
||||
JSONModel.objects.filter(field__foo=KeyTransform('x', expr)),
|
||||
[self.objs[-1]],
|
||||
)
|
||||
|
||||
def test_key_transform_expression(self):
|
||||
self.assertSequenceEqual(
|
||||
JSONModel.objects.filter(field__d__0__isnull=False).annotate(
|
||||
key=KeyTransform('d', 'field'),
|
||||
chain=KeyTransform('0', 'key'),
|
||||
expr=KeyTransform('0', Cast('key', JSONField())),
|
||||
).filter(chain=F('expr')),
|
||||
[self.objs[8]],
|
||||
)
|
||||
|
||||
def test_deep_values(self):
|
||||
query = JSONModel.objects.values_list('field__k__l')
|
||||
self.assertSequenceEqual(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue