mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Added safety to URL decoding in is_safe_url() on Python 2

Browse source 
The errors='replace' parameter to force_text altered the URL before checking
it, which wasn't considered sane. Refs 24fc935218 and ada7a4aef.
This commit is contained in:
Claude Paroz 2016-03-04 23:33:35 +01:00
parent ada7a4aefb
commit 552f03869e
4 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/utils_tests/test_http.py
View file

@ -124,7 +124,7 @@ class TestUtilsHttp(unittest.TestCase):
)
self.assertFalse(http.is_safe_url(b'\x08//example.com', host='testserver'))
self.assertTrue(http.is_safe_url('àview/'.encode('utf-8'), host='testserver'))
self.assertTrue(http.is_safe_url('àview'.encode('latin-1'), host='testserver'))
self.assertFalse(http.is_safe_url('àview'.encode('latin-1'), host='testserver'))
# Valid basic auth credentials are allowed.
self.assertTrue(http.is_safe_url(r'http://user:pass@testserver/', host='user:pass@testserver'))