mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-03 10:34:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #26352 -- Made system check allow ManyToManyField to target the same model if through_fields differs.

Browse source
This commit is contained in:
Simon Willison 2018-07-18 15:21:40 -07:00 • committed by Tim Graham
parent f2d5dafec9
commit 586a9dc429
3 changed files with 29 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/invalid_models_tests/test_models.py
View file

@ -771,13 +771,35 @@ class OtherModelTests(SimpleTestCase):
self.assertEqual(Group.check(), [
Error(
"The model has two many-to-many relations through "
"The model has two identical many-to-many relations through "
"the intermediate model 'invalid_models_tests.Membership'.",
obj=Group,
id='models.E003',
)
])
def test_two_m2m_through_same_model_with_different_through_fields(self):
class Country(models.Model):
pass
class ShippingMethod(models.Model):
to_countries = models.ManyToManyField(
Country, through='ShippingMethodPrice',
through_fields=('method', 'to_country'),
)
from_countries = models.ManyToManyField(
Country, through='ShippingMethodPrice',
through_fields=('method', 'from_country'),
related_name='+',
)
class ShippingMethodPrice(models.Model):
method = models.ForeignKey(ShippingMethod, models.CASCADE)
to_country = models.ForeignKey(Country, models.CASCADE)
from_country = models.ForeignKey(Country, models.CASCADE)
self.assertEqual(ShippingMethod.check(), [])
def test_missing_parent_link(self):
msg = 'Add parent_link=True to invalid_models_tests.ParkingLot.parent.'
with self.assertRaisesMessage(ImproperlyConfigured, msg):