mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refs #17144 -- Removed support for grouping by primary key.

Browse source 
No core backend require the feature anymore as it was only added to
support a MySQL'ism that has been deprecated since then.
This commit is contained in:
Simon Charette 2022-11-05 12:49:33 -04:00 • committed by Mariusz Felisiak
parent 041551d716
commit 5f09ab8c30
5 changed files with 15 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/annotations/tests.py
View file

@ -550,21 +550,6 @@ class NonAggregateAnnotationTestCase(TestCase):
for publisher in publishers.filter(pk=self.p1.pk):
self.assertEqual(publisher["book__rating"], publisher["total"])
@skipUnlessDBFeature("allows_group_by_pk")
def test_rawsql_group_by_collapse(self):
raw = RawSQL("SELECT MIN(id) FROM annotations_book", [])
qs = (
Author.objects.values("id")
.annotate(
min_book_id=raw,
count_friends=Count("friends"),
)
.order_by()
)
_, _, group_by = qs.query.get_compiler(using="default").pre_sql_setup()
self.assertEqual(len(group_by), 1)
self.assertNotEqual(raw, group_by[0])
def test_defer_annotation(self):
"""
Deferred attributes can be referenced by an annotation,