mirror of
https://github.com/django/django.git
synced 2025-08-03 10:34:04 +00:00
Thanks to Adam Johnson, Carlton Gibson, Mariusz Felisiak, and Raphael Michel for mentoring this Google Summer of Code 2019 project and everyone else who helped with the patch. Special thanks to Mads Jensen, Nick Pope, and Simon Charette for extensive reviews. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
parent
f97f71f592
commit
6789ded0a6
54 changed files with 2240 additions and 981 deletions
|
@ -5,7 +5,7 @@ from django.core.checks.model_checks import _check_lazy_references
|
|||
from django.db import connection, connections, models
|
||||
from django.db.models.functions import Lower
|
||||
from django.db.models.signals import post_init
|
||||
from django.test import SimpleTestCase, TestCase
|
||||
from django.test import SimpleTestCase, TestCase, skipUnlessDBFeature
|
||||
from django.test.utils import isolate_apps, override_settings, register_lookup
|
||||
|
||||
|
||||
|
@ -1349,6 +1349,40 @@ class OtherModelTests(SimpleTestCase):
|
|||
])
|
||||
|
||||
|
||||
@isolate_apps('invalid_models_tests')
|
||||
class JSONFieldTests(TestCase):
|
||||
@skipUnlessDBFeature('supports_json_field')
|
||||
def test_ordering_pointing_to_json_field_value(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField()
|
||||
|
||||
class Meta:
|
||||
ordering = ['field__value']
|
||||
|
||||
self.assertEqual(Model.check(databases=self.databases), [])
|
||||
|
||||
def test_check_jsonfield(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField()
|
||||
|
||||
error = Error(
|
||||
'%s does not support JSONFields.' % connection.display_name,
|
||||
obj=Model,
|
||||
id='fields.E180',
|
||||
)
|
||||
expected = [] if connection.features.supports_json_field else [error]
|
||||
self.assertEqual(Model.check(databases=self.databases), expected)
|
||||
|
||||
def test_check_jsonfield_required_db_features(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField()
|
||||
|
||||
class Meta:
|
||||
required_db_features = {'supports_json_field'}
|
||||
|
||||
self.assertEqual(Model.check(databases=self.databases), [])
|
||||
|
||||
|
||||
@isolate_apps('invalid_models_tests')
|
||||
class ConstraintsTests(TestCase):
|
||||
def test_check_constraints(self):
|
||||
|
|
|
@ -3,7 +3,9 @@ import uuid
|
|||
|
||||
from django.core.checks import Error, Warning as DjangoWarning
|
||||
from django.db import connection, models
|
||||
from django.test import SimpleTestCase, TestCase, skipIfDBFeature
|
||||
from django.test import (
|
||||
SimpleTestCase, TestCase, skipIfDBFeature, skipUnlessDBFeature,
|
||||
)
|
||||
from django.test.utils import isolate_apps, override_settings
|
||||
from django.utils.functional import lazy
|
||||
from django.utils.timezone import now
|
||||
|
@ -793,3 +795,47 @@ class UUIDFieldTests(TestCase):
|
|||
)
|
||||
|
||||
self.assertEqual(Model._meta.get_field('field').check(), [])
|
||||
|
||||
|
||||
@isolate_apps('invalid_models_tests')
|
||||
@skipUnlessDBFeature('supports_json_field')
|
||||
class JSONFieldTests(TestCase):
|
||||
def test_invalid_default(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField(default={})
|
||||
|
||||
self.assertEqual(Model._meta.get_field('field').check(), [
|
||||
DjangoWarning(
|
||||
msg=(
|
||||
"JSONField default should be a callable instead of an "
|
||||
"instance so that it's not shared between all field "
|
||||
"instances."
|
||||
),
|
||||
hint=(
|
||||
'Use a callable instead, e.g., use `dict` instead of `{}`.'
|
||||
),
|
||||
obj=Model._meta.get_field('field'),
|
||||
id='fields.E010',
|
||||
)
|
||||
])
|
||||
|
||||
def test_valid_default(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField(default=dict)
|
||||
|
||||
self.assertEqual(Model._meta.get_field('field').check(), [])
|
||||
|
||||
def test_valid_default_none(self):
|
||||
class Model(models.Model):
|
||||
field = models.JSONField(default=None)
|
||||
|
||||
self.assertEqual(Model._meta.get_field('field').check(), [])
|
||||
|
||||
def test_valid_callable_default(self):
|
||||
def callable_default():
|
||||
return {'it': 'works'}
|
||||
|
||||
class Model(models.Model):
|
||||
field = models.JSONField(default=callable_default)
|
||||
|
||||
self.assertEqual(Model._meta.get_field('field').check(), [])
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue