mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-17 18:48:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixed #36053 -- Fixed placement of FilteredSelectMultiple widget label.

Browse source
This commit is contained in:
Dani Fornons 2025-11-10 10:21:46 +01:00 • committed by Jacob Walls
parent 2b0f24e622
commit 6821a7c990
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
django/contrib/admin/static/admin/js/SelectFilter2.js
View file

@ -32,9 +32,8 @@ Requires core.js and SelectBox.js.
// <div class="selector"> or <div class="selector stacked">
const selector_div = quickElement('div', from_box.parentNode);
// Make sure the selector div is at the beginning so that the
// add link would be displayed to the right of the widget.
from_box.parentNode.prepend(selector_div);
// Make sure the selector div appears between the label and the add link.
from_box.parentNode.insertBefore(selector_div, from_box.nextSibling);
selector_div.className = is_stacked ? 'selector stacked' : 'selector';
// <div class="selector-available">

7
js_tests/admin/SelectFilter2.test.js
View file

@ -10,8 +10,11 @@ QUnit.test('init', function(assert) {
$('<div class="helptext">This is helpful.</div>').appendTo('#test');
$('<select id="id"><option value="0">A</option></select>').appendTo('#test');
SelectFilter.init('id', 'things', 0);
assert.equal($('#test').children().first().prop("tagName"), "DIV");
assert.equal($('#test').children().first().attr("class"), "selector");
assert.deepEqual(
Array.from($('#test')[0].children).map(child => child.tagName),
["LABEL", "DIV", "DIV"]
);
assert.equal($('.helptext')[0].nextSibling.getAttribute("class"), "selector");
assert.equal($('.selector-available label').text().trim(), "Available things");
assert.equal($('.selector-available label').attr("id"), "id_from_label");
assert.equal($('.selector-chosen label').text().trim(), "Chosen things");