mirror of
https://github.com/django/django.git
synced 2025-08-04 02:48:35 +00:00
Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()."
This reverts commit 550cb3a365
because try/except performs better.
This commit is contained in:
parent
8b2515a450
commit
6e4c6281db
66 changed files with 351 additions and 207 deletions
|
@ -1,5 +1,4 @@
|
|||
import json
|
||||
from contextlib import suppress
|
||||
|
||||
from django.db.models.expressions import F, Value
|
||||
from django.test.testcases import skipUnlessDBFeature
|
||||
|
@ -8,12 +7,14 @@ from django.test.utils import Approximate
|
|||
from . import PostgreSQLTestCase
|
||||
from .models import AggregateTestModel, StatTestModel
|
||||
|
||||
with suppress(ImportError): # psycopg2 is not installed
|
||||
try:
|
||||
from django.contrib.postgres.aggregates import (
|
||||
ArrayAgg, BitAnd, BitOr, BoolAnd, BoolOr, Corr, CovarPop, JSONBAgg,
|
||||
RegrAvgX, RegrAvgY, RegrCount, RegrIntercept, RegrR2, RegrSlope,
|
||||
RegrSXX, RegrSXY, RegrSYY, StatAggregate, StringAgg,
|
||||
)
|
||||
except ImportError:
|
||||
pass # psycopg2 is not installed
|
||||
|
||||
|
||||
class TestGeneralAggregate(PostgreSQLTestCase):
|
||||
|
|
|
@ -2,7 +2,6 @@ import decimal
|
|||
import json
|
||||
import unittest
|
||||
import uuid
|
||||
from contextlib import suppress
|
||||
|
||||
from django import forms
|
||||
from django.core import exceptions, serializers, validators
|
||||
|
@ -20,11 +19,13 @@ from .models import (
|
|||
PostgreSQLModel, Tag,
|
||||
)
|
||||
|
||||
with suppress(ImportError):
|
||||
try:
|
||||
from django.contrib.postgres.fields import ArrayField
|
||||
from django.contrib.postgres.forms import (
|
||||
SimpleArrayField, SplitArrayField, SplitArrayWidget,
|
||||
)
|
||||
except ImportError:
|
||||
pass
|
||||
|
||||
|
||||
class TestSaveLoad(PostgreSQLTestCase):
|
||||
|
|
|
@ -1,5 +1,4 @@
|
|||
import json
|
||||
from contextlib import suppress
|
||||
|
||||
from django.core import exceptions, serializers
|
||||
from django.forms import Form
|
||||
|
@ -8,10 +7,12 @@ from django.test.utils import modify_settings
|
|||
from . import PostgreSQLTestCase
|
||||
from .models import HStoreModel
|
||||
|
||||
with suppress(ImportError):
|
||||
try:
|
||||
from django.contrib.postgres import forms
|
||||
from django.contrib.postgres.fields import HStoreField
|
||||
from django.contrib.postgres.validators import KeysValidator
|
||||
except ImportError:
|
||||
pass
|
||||
|
||||
|
||||
@modify_settings(INSTALLED_APPS={'append': 'django.contrib.postgres'})
|
||||
|
|
|
@ -1,6 +1,5 @@
|
|||
import datetime
|
||||
import uuid
|
||||
from contextlib import suppress
|
||||
from decimal import Decimal
|
||||
|
||||
from django.core import exceptions, serializers
|
||||
|
@ -12,9 +11,11 @@ from django.utils.html import escape
|
|||
from . import PostgreSQLTestCase
|
||||
from .models import JSONModel
|
||||
|
||||
with suppress(ImportError):
|
||||
try:
|
||||
from django.contrib.postgres import forms
|
||||
from django.contrib.postgres.fields import JSONField
|
||||
except ImportError:
|
||||
pass
|
||||
|
||||
|
||||
@skipUnlessDBFeature('has_jsonb_datatype')
|
||||
|
|
|
@ -1,6 +1,5 @@
|
|||
import datetime
|
||||
import json
|
||||
from contextlib import suppress
|
||||
|
||||
from django import forms
|
||||
from django.core import exceptions, serializers
|
||||
|
@ -11,12 +10,14 @@ from django.utils import timezone
|
|||
from . import PostgreSQLTestCase
|
||||
from .models import RangeLookupsModel, RangesModel
|
||||
|
||||
with suppress(ImportError):
|
||||
try:
|
||||
from psycopg2.extras import DateRange, DateTimeTZRange, NumericRange
|
||||
from django.contrib.postgres import fields as pg_fields, forms as pg_forms
|
||||
from django.contrib.postgres.validators import (
|
||||
RangeMaxValueValidator, RangeMinValueValidator,
|
||||
)
|
||||
except ImportError:
|
||||
pass
|
||||
|
||||
|
||||
class TestSaveLoad(PostgreSQLTestCase):
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue