mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-17 17:20:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[1.9.x] Fixed #26332 -- Fixed a race condition in BaseCache.get_or_set().

Browse source 
Backport of 96ec67a7cf from master
This commit is contained in:
Przemysław Suliga 2016-03-06 11:34:23 +01:00 • committed by Tim Graham
parent 809eb5ddee
commit 76926f343a
3 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/cache/tests.py vendored
View file

@ -30,7 +30,7 @@ from django.template import engines
from django.template.context_processors import csrf
from django.template.response import TemplateResponse
from django.test import (
RequestFactory, SimpleTestCase, TestCase, TransactionTestCase,
RequestFactory, SimpleTestCase, TestCase, TransactionTestCase, mock,
override_settings,
)
from django.test.signals import setting_changed
@ -915,6 +915,13 @@ class BaseCacheTests(object):
self.assertEqual(cache.get_or_set('brian', 1979, version=2), 1979)
self.assertIsNone(cache.get('brian', version=3))
def test_get_or_set_racing(self):
with mock.patch('%s.%s' % (settings.CACHES['default']['BACKEND'], 'add')) as cache_add:
# Simulate cache.add() failing to add a value. In that case, the
# default value should be returned.
cache_add.return_value = False
self.assertEqual(cache.get_or_set('key', 'default'), 'default')
@override_settings(CACHES=caches_setting_for_tests(
BACKEND='django.core.cache.backends.db.DatabaseCache',