mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-06 08:40:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[4.1.x] Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a noop for models with db_table."

Browse source 
Regression in afeafd6036.
This reverts afeafd6036.

Thanks Timothy Thomas for the report.

Backport of 166a3b3263 from main
This commit is contained in:
Iuri de Silvio 2022-08-24 10:10:56 -03:00 • committed by Mariusz Felisiak
parent c9ebd5b7aa
commit 7d5ccbbe1a
3 changed files with 20 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/migrations/test_operations.py
View file

@ -1052,8 +1052,8 @@ class OperationTests(OperationTestBase):
Pony._meta.get_field("riders").remote_field.through.objects.count(), 2
)
def test_rename_model_with_db_table_noop(self):
app_label = "test_rmwdbtn"
def test_rename_model_with_db_table_rename_m2m(self):
app_label = "test_rmwdbrm2m"
project_state = self.apply_operations(
app_label,
ProjectState(),
@ -1063,32 +1063,28 @@ class OperationTests(OperationTestBase):
fields=[
("id", models.AutoField(primary_key=True)),
],
options={"db_table": "rider"},
),
migrations.CreateModel(
"Pony",
fields=[
("id", models.AutoField(primary_key=True)),
(
"rider",
models.ForeignKey("%s.Rider" % app_label, models.CASCADE),
),
("riders", models.ManyToManyField("Rider")),
],
options={"db_table": "pony"},
),
],
)
new_state = project_state.clone()
operation = migrations.RenameModel("Rider", "Runner")
operation = migrations.RenameModel("Pony", "PinkPony")
operation.state_forwards(app_label, new_state)
with connection.schema_editor() as editor:
operation.database_forwards(app_label, editor, project_state, new_state)
with connection.schema_editor() as editor:
with self.assertNumQueries(0):
operation.database_forwards(app_label, editor, project_state, new_state)
with connection.schema_editor() as editor:
with self.assertNumQueries(0):
operation.database_backwards(
app_label, editor, new_state, project_state
)
Pony = new_state.apps.get_model(app_label, "PinkPony")
Rider = new_state.apps.get_model(app_label, "Rider")
pony = Pony.objects.create()
rider = Rider.objects.create()
pony.riders.add(rider)
def test_rename_m2m_target_model(self):
app_label = "test_rename_m2m_target_model"