mirror of
https://github.com/django/django.git
synced 2025-07-24 21:54:14 +00:00
Fixed #25535 -- Made ForeignObject checks less strict.
Check that the foreign object `from_fields` are a subset of any unique constraints on the foreign model.
This commit is contained in:
parent
533c10998a
commit
80dac8c33e
3 changed files with 159 additions and 9 deletions
|
@ -2,6 +2,8 @@ import datetime
|
|||
from operator import attrgetter
|
||||
|
||||
from django.core.exceptions import FieldError
|
||||
from django.db import models
|
||||
from django.db.models.fields.related import ForeignObject
|
||||
from django.test import TestCase, skipUnlessDBFeature
|
||||
from django.utils import translation
|
||||
|
||||
|
@ -391,3 +393,61 @@ class MultiColumnFKTests(TestCase):
|
|||
""" See: https://code.djangoproject.com/ticket/21566 """
|
||||
objs = [Person(name="abcd_%s" % i, person_country=self.usa) for i in range(0, 5)]
|
||||
Person.objects.bulk_create(objs, 10)
|
||||
|
||||
def test_check_composite_foreign_object(self):
|
||||
class Parent(models.Model):
|
||||
a = models.PositiveIntegerField()
|
||||
b = models.PositiveIntegerField()
|
||||
|
||||
class Meta:
|
||||
unique_together = (
|
||||
('a', 'b'),
|
||||
)
|
||||
|
||||
class Child(models.Model):
|
||||
a = models.PositiveIntegerField()
|
||||
b = models.PositiveIntegerField()
|
||||
value = models.CharField(max_length=255)
|
||||
|
||||
parent = ForeignObject(
|
||||
Parent,
|
||||
on_delete=models.SET_NULL,
|
||||
from_fields=('a', 'b'),
|
||||
to_fields=('a', 'b'),
|
||||
related_name='children',
|
||||
)
|
||||
|
||||
field = Child._meta.get_field('parent')
|
||||
errors = field.check(from_model=Child)
|
||||
|
||||
self.assertEqual(errors, [])
|
||||
|
||||
def test_check_subset_composite_foreign_object(self):
|
||||
class Parent(models.Model):
|
||||
a = models.PositiveIntegerField()
|
||||
b = models.PositiveIntegerField()
|
||||
c = models.PositiveIntegerField()
|
||||
|
||||
class Meta:
|
||||
unique_together = (
|
||||
('a', 'b'),
|
||||
)
|
||||
|
||||
class Child(models.Model):
|
||||
a = models.PositiveIntegerField()
|
||||
b = models.PositiveIntegerField()
|
||||
c = models.PositiveIntegerField()
|
||||
d = models.CharField(max_length=255)
|
||||
|
||||
parent = ForeignObject(
|
||||
Parent,
|
||||
on_delete=models.SET_NULL,
|
||||
from_fields=('a', 'b', 'c'),
|
||||
to_fields=('a', 'b', 'c'),
|
||||
related_name='children',
|
||||
)
|
||||
|
||||
field = Child._meta.get_field('parent')
|
||||
errors = field.check(from_model=Child)
|
||||
|
||||
self.assertEqual(errors, [])
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue