mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-03 18:38:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #28431 -- Added a system check for BinaryField to prevent strings defaults.

Browse source 
Thanks Claude Paroz for the initial patch.
This commit is contained in:
Hasan Ramezani 2019-03-17 21:47:21 +01:00 • committed by Mariusz Felisiak
parent dc53f2135b
commit 981dd6dd71
No known key found for this signature in database
GPG key ID: 2EF56372BA48CD1B
3 changed files with 44 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

27
tests/invalid_models_tests/test_ordinary_fields.py
View file

@ -39,6 +39,33 @@ class AutoFieldTests(SimpleTestCase):
])
@isolate_apps('invalid_models_tests')
class BinaryFieldTests(SimpleTestCase):
def test_valid_default_value(self):
class Model(models.Model):
field1 = models.BinaryField(default=b'test')
field2 = models.BinaryField(default=None)
for field_name in ('field1', 'field2'):
field = Model._meta.get_field(field_name)
self.assertEqual(field.check(), [])
def test_str_default_value(self):
class Model(models.Model):
field = models.BinaryField(default='test')
field = Model._meta.get_field('field')
self.assertEqual(field.check(), [
Error(
"BinaryField's default cannot be a string. Use bytes content "
"instead.",
obj=field,
id='fields.E170',
),
])
@isolate_apps('invalid_models_tests')
class CharFieldTests(SimpleTestCase):