mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 10:59:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[3.2.x] Fixed #32652 -- Fixed links to new contributors FAQ.

Browse source 
Backport of e3e2276e6f from main
This commit is contained in:
Carlton Gibson 2021-04-14 20:23:21 +02:00
parent 539d005aa5
commit 99ea737a0f
3 changed files with 33 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

37
docs/internals/contributing/new-contributors.txt
View file

@ -138,25 +138,20 @@ some advice to make your work on Django more useful and rewarding.
writing the very first tests for that feature, not that you get a pass from
writing tests altogether.
* **Be patient**
It's not always easy for your ticket or your patch to be reviewed quickly.
This isn't personal. There are a lot of tickets and pull requests to get
through.
Keeping your patch up to date is important. Review the ticket on Trac to
ensure that the *Needs tests*, *Needs documentation*, and *Patch needs
improvement* flags are unchecked once you've addressed all review comments.
Remember that Django has an 8 month release cycle, so there's plenty of time
for your patch to be reviewed.
Finally, a well-timed reminder can help. See :ref:`contributing code FAQ
<new-contributors-faq>` for ideas here.
.. _easy pickings: https://code.djangoproject.com/query?status=!closed&easy=1
.. _new-contributors-faq:
FAQ
===
1. **This ticket I care about has been ignored for days/weeks/months! What can
I do to get it committed?**
First off, it's not personal. Django is entirely developed by volunteers
(except the Django fellow), and sometimes folks just don't have time. The
best thing to do is to send a gentle reminder to the |django-developers|
mailing list asking for review on the ticket, or to bring it up in the
``#django-dev`` IRC channel.
2. **I'm sure my ticket is absolutely 100% perfect, can I mark it as RFC
myself?**
Short answer: No. It's always better to get another set of eyes on a
ticket. If you're having trouble getting that second set of eyes, see
question 1, above.

8
docs/internals/contributing/triaging-tickets.txt
View file

@ -143,9 +143,11 @@ Ready For Checkin
The ticket was reviewed by any member of the community other than the person
who supplied the patch and found to meet all the requirements for a
commit-ready patch. A committer now needs to give the patch a final
review prior to being committed. See the
:ref:`New contributors' FAQ<new-contributors-faq>` for "My ticket has been in
RFC forever! What should I do?"
review prior to being committed.
There are a lot of pull requests. It can take a while for your patch to get
reviewed. See the :ref:`contributing code FAQ<new-contributors-faq>` for some
ideas here.
Someday/Maybe
-------------