mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-03 18:38:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refs #35090 -- Removed support for django.urls.register_converter() overriding existing converters per deprecation timeline.

Browse source
This commit is contained in:
Sarah Boyce 2024-12-12 17:11:22 +01:00
parent 1e331911a8
commit 9cb1ffa67b
5 changed files with 10 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/urlpatterns/tests.py
View file

@ -13,8 +13,7 @@ from django.urls import (
resolve,
reverse,
)
from django.urls.converters import REGISTERED_CONVERTERS, IntConverter
from django.utils.deprecation import RemovedInDjango60Warning
from django.urls.converters import IntConverter
from django.views import View
from .converters import Base64Converter, DynamicConverter
@ -204,35 +203,14 @@ class SimplifiedURLTests(SimpleTestCase):
path("foo/<nonexistent:var>/", empty_view)
def test_warning_override_default_converter(self):
# RemovedInDjango60Warning: when the deprecation ends, replace with
# msg = "Converter 'int' is already registered."
# with self.assertRaisesMessage(ValueError, msg):
msg = (
"Converter 'int' is already registered. Support for overriding registered "
"converters is deprecated and will be removed in Django 6.0."
)
try:
with self.assertWarnsMessage(RemovedInDjango60Warning, msg) as ctx:
register_converter(IntConverter, "int")
finally:
REGISTERED_CONVERTERS.pop("int", None)
self.assertEqual(ctx.filename, __file__)
msg = "Converter 'int' is already registered."
with self.assertRaisesMessage(ValueError, msg):
register_converter(IntConverter, "int")
def test_warning_override_converter(self):
# RemovedInDjango60Warning: when the deprecation ends, replace with
# msg = "Converter 'base64' is already registered."
# with self.assertRaisesMessage(ValueError, msg):
msg = (
"Converter 'base64' is already registered. Support for overriding "
"registered converters is deprecated and will be removed in Django 6.0."
)
try:
with self.assertWarnsMessage(RemovedInDjango60Warning, msg) as ctx:
register_converter(Base64Converter, "base64")
register_converter(Base64Converter, "base64")
finally:
REGISTERED_CONVERTERS.pop("base64", None)
self.assertEqual(ctx.filename, __file__)
msg = "Converter 'base64' is already registered."
with self.assertRaisesMessage(ValueError, msg):
register_converter(Base64Converter, "base64")
def test_invalid_view(self):
msg = "view must be a callable or a list/tuple in the case of include()."