mirror of
https://github.com/django/django.git
synced 2025-10-02 23:04:53 +00:00
Fixed #22994 -- regression with generic FK + admin list_view
The reason for the regression was that the GenericForeignKey field isn't something meta.get_field_by_name() should return. The reason is that a couple of places in Django expects get_field_by_name() to work this way. It could make sense to return GFKs from get_field_by_name(), but that should likely be done as part of meta refactoring or virtual fields refactoring patches. Thanks to glicerinu@gmail.com for the report and to Tim for working on the issue.
This commit is contained in:
parent
38e001ab6c
commit
9cd5201abd
4 changed files with 35 additions and 8 deletions
|
@ -35,7 +35,7 @@ from .models import (Article, Chapter, Child, Parent, Picture, Widget,
|
|||
UnchangeableObject, UserMessenger, Simple, Choice, ShortMessage, Telegram,
|
||||
FilteredManager, EmptyModelHidden, EmptyModelVisible, EmptyModelMixin,
|
||||
State, City, Restaurant, Worker, ParentWithDependentChildren,
|
||||
DependentChild, StumpJoke, FieldOverridePost)
|
||||
DependentChild, StumpJoke, FieldOverridePost, FunkyTag)
|
||||
|
||||
|
||||
def callable_year(dt_value):
|
||||
|
@ -827,6 +827,10 @@ class RestaurantAdmin(admin.ModelAdmin):
|
|||
return {'name': 'overridden_value'}
|
||||
|
||||
|
||||
class FunkyTagAdmin(admin.ModelAdmin):
|
||||
list_display = ('name', 'content_object')
|
||||
|
||||
|
||||
site = admin.AdminSite(name="admin")
|
||||
site.register(Article, ArticleAdmin)
|
||||
site.register(CustomArticle, CustomArticleAdmin)
|
||||
|
@ -882,6 +886,7 @@ site.register(State, StateAdmin)
|
|||
site.register(City, CityAdmin)
|
||||
site.register(Restaurant, RestaurantAdmin)
|
||||
site.register(Worker, WorkerAdmin)
|
||||
site.register(FunkyTag, FunkyTagAdmin)
|
||||
|
||||
# We intentionally register Promo and ChapterXtra1 but not Chapter nor ChapterXtra2.
|
||||
# That way we cover all four cases:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue