mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-07-24 13:44:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Removed an inactive system check for upload_to.

Browse source 
Thanks to Simon Charette for the eagle eyes.
This commit is contained in:
Russell Keith-Magee 2014-01-20 12:31:35 +08:00
parent be8173af51
commit a029efca44
2 changed files with 0 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

14
django/db/models/fields/files.py
View file

@ -238,24 +238,10 @@ class FileField(Field):
def check(self, **kwargs): def check(self, **kwargs):
errors = super(FileField, self).check(**kwargs) errors = super(FileField, self).check(**kwargs)
#errors.extend(self._check_upload_to())
errors.extend(self._check_unique()) errors.extend(self._check_unique())
errors.extend(self._check_primary_key()) errors.extend(self._check_primary_key())
return errors return errors
def _check_upload_to(self):
if not self.upload_to:
return [
checks.Error(
'The field requires an "upload_to" attribute.',
hint=None,
obj=self,
id='E031',
)
]
else:
return []
def _check_unique(self): def _check_unique(self):
if self._unique_set_explicitly: if self._unique_set_explicitly:
return [ return [

16
tests/invalid_models_tests/test_ordinary_fields.py
View file

@ -302,22 +302,6 @@ class FileFieldTests(IsolatedModelsTestCase):
expected = [] expected = []
self.assertEqual(errors, expected) self.assertEqual(errors, expected)
# def test_missing_upload_to(self):
# class Model(models.Model):
# field = models.FileField()
# field = Model._meta.get_field('field')
# errors = field.check()
# expected = [
# Error(
# 'The field requires an "upload_to" attribute.',
# hint=None,
# obj=field,
# id='E031',
# ),
# ]
# self.assertEqual(errors, expected)
def test_unique(self): def test_unique(self):
class Model(models.Model): class Model(models.Model):
field = models.FileField(unique=False, upload_to='somewhere') field = models.FileField(unique=False, upload_to='somewhere')