mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #29133 -- Fixed call_command() crash if a required option is passed in options.

Browse source
This commit is contained in:
Alex Tomic 2018-03-02 12:25:08 -05:00 • committed by Tim Graham
parent 40bac28faa
commit a1a3e51561
3 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/user_commands/management/commands/required_option.py Normal file
View file

@ -0,0 +1,11 @@
from django.core.management.base import BaseCommand
class Command(BaseCommand):
def add_arguments(self, parser):
parser.add_argument('-n', '--need-me', required=True)
parser.add_argument('-t', '--need-me-too', required=True, dest='needme2')
def handle(self, *args, **options):
self.stdout.write(','.join(options))

12
tests/user_commands/tests.py
View file

@ -194,6 +194,18 @@ class CommandTests(SimpleTestCase):
with self.assertRaisesMessage(TypeError, msg):
management.call_command('dance', unrecognized=1, unrecognized2=1)
def test_call_command_with_required_parameters_in_options(self):
out = StringIO()
management.call_command('required_option', need_me='foo', needme2='bar', stdout=out)
self.assertIn('need_me', out.getvalue())
self.assertIn('needme2', out.getvalue())
def test_call_command_with_required_parameters_in_mixed_options(self):
out = StringIO()
management.call_command('required_option', '--need-me=foo', needme2='bar', stdout=out)
self.assertIn('need_me', out.getvalue())
self.assertIn('needme2', out.getvalue())
class CommandRunTests(AdminScriptTestCase):
"""