mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set.

Browse source
This commit is contained in:
Jon Dufresne 2018-04-13 13:18:53 -07:00 • committed by Tim Graham
parent fff689ed98
commit b3cffde555
5 changed files with 40 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/admin_scripts/tests.py
View file

@ -2213,7 +2213,11 @@ class DiffSettings(AdminScriptTestCase):
out, err = self.run_manage(args)
self.assertNoOutput(err)
self.assertOutput(out, "+ FOO = 'bar'")
self.assertOutput(out, "- SECRET_KEY = ''")
self.assertOutput(out, "- INSTALLED_APPS = []")
self.assertOutput(
out,
"+ INSTALLED_APPS = ['django.contrib.auth', 'django.contrib.contenttypes', 'admin_scripts']"
)
self.assertOutput(out, "+ SECRET_KEY = 'django_tests_secret_key'")
self.assertNotInOutput(out, " APPEND_SLASH = True")
@ -2229,7 +2233,12 @@ class DiffSettings(AdminScriptTestCase):
self.assertNoOutput(err)
self.assertOutput(out, " APPEND_SLASH = True")
self.assertOutput(out, "+ FOO = 'bar'")
self.assertOutput(out, "- SECRET_KEY = ''")
self.assertOutput(out, "- INSTALLED_APPS = []")
self.assertOutput(
out,
"+ INSTALLED_APPS = ['django.contrib.auth', 'django.contrib.contenttypes', 'admin_scripts']"
)
self.assertOutput(out, "+ SECRET_KEY = 'django_tests_secret_key'")
class Dumpdata(AdminScriptTestCase):