mirror of
https://github.com/django/django.git
synced 2025-08-04 19:08:28 +00:00
Fixing E302 Errors
Signed-off-by: Jason Myers <jason@jasonamyers.com>
This commit is contained in:
parent
2a03a9a9a1
commit
c3791463a5
98 changed files with 748 additions and 96 deletions
|
@ -1,4 +1,5 @@
|
|||
import non_existent # NOQA
|
||||
|
||||
|
||||
def erroneous_view(request):
|
||||
pass
|
||||
|
|
|
@ -8,24 +8,29 @@ class ChangeURLconfMiddleware(object):
|
|||
def process_request(self, request):
|
||||
request.urlconf = urlconf_inner.__name__
|
||||
|
||||
|
||||
class NullChangeURLconfMiddleware(object):
|
||||
def process_request(self, request):
|
||||
request.urlconf = None
|
||||
|
||||
|
||||
class ReverseInnerInResponseMiddleware(object):
|
||||
def process_response(self, *args, **kwargs):
|
||||
return HttpResponse(reverse('inner'))
|
||||
|
||||
|
||||
class ReverseOuterInResponseMiddleware(object):
|
||||
def process_response(self, *args, **kwargs):
|
||||
return HttpResponse(reverse('outer'))
|
||||
|
||||
|
||||
class ReverseInnerInStreaming(object):
|
||||
def process_view(self, *args, **kwargs):
|
||||
def stream():
|
||||
yield reverse('inner')
|
||||
return StreamingHttpResponse(stream())
|
||||
|
||||
|
||||
class ReverseOuterInStreaming(object):
|
||||
def process_view(self, *args, **kwargs):
|
||||
def stream():
|
||||
|
|
|
@ -148,6 +148,7 @@ test_data = (
|
|||
('defaults', NoReverseMatch, [], {'arg2': 1}),
|
||||
)
|
||||
|
||||
|
||||
class NoURLPatternsTests(TestCase):
|
||||
urls = 'urlpatterns_reverse.no_urls'
|
||||
|
||||
|
@ -161,6 +162,7 @@ class NoURLPatternsTests(TestCase):
|
|||
"The included urlconf urlpatterns_reverse.no_urls "
|
||||
"doesn't have any patterns in it", getattr, resolver, 'url_patterns')
|
||||
|
||||
|
||||
class URLPatternReverse(TestCase):
|
||||
urls = 'urlpatterns_reverse.urls'
|
||||
|
||||
|
@ -282,6 +284,7 @@ class ResolverTests(unittest.TestCase):
|
|||
else:
|
||||
self.assertEqual(t.name, e['name'], 'Wrong URL name. Expected "%s", got "%s".' % (e['name'], t.name))
|
||||
|
||||
|
||||
class ReverseLazyTest(TestCase):
|
||||
urls = 'urlpatterns_reverse.reverse_lazy_urls'
|
||||
|
||||
|
@ -297,6 +300,7 @@ class ReverseLazyTest(TestCase):
|
|||
response = self.client.get('/login_required_view/')
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
|
||||
class ReverseShortcutTests(TestCase):
|
||||
urls = 'urlpatterns_reverse.urls'
|
||||
|
||||
|
@ -454,7 +458,7 @@ class NamespaceTests(TestCase):
|
|||
self.assertEqual('/inc78/extra/foobar/', reverse('inc-ns5:inner-extra', args=['78', 'foobar']))
|
||||
|
||||
|
||||
@override_settings(ROOT_URLCONF = urlconf_outer.__name__)
|
||||
@override_settings(ROOT_URLCONF=urlconf_outer.__name__)
|
||||
class RequestURLconfTests(TestCase):
|
||||
def test_urlconf(self):
|
||||
response = self.client.get('/test/me/')
|
||||
|
@ -549,6 +553,7 @@ class RequestURLconfTests(TestCase):
|
|||
self.client.get('/second_test/')
|
||||
b''.join(self.client.get('/second_test/'))
|
||||
|
||||
|
||||
class ErrorHandlerResolutionTests(TestCase):
|
||||
"""Tests for handler400, handler404 and handler500"""
|
||||
|
||||
|
@ -573,6 +578,7 @@ class ErrorHandlerResolutionTests(TestCase):
|
|||
self.assertEqual(self.callable_resolver.resolve404(), handler)
|
||||
self.assertEqual(self.callable_resolver.resolve500(), handler)
|
||||
|
||||
|
||||
class DefaultErrorHandlerTests(TestCase):
|
||||
urls = 'urlpatterns_reverse.urls_without_full_import'
|
||||
|
||||
|
@ -589,6 +595,7 @@ class DefaultErrorHandlerTests(TestCase):
|
|||
except AttributeError:
|
||||
self.fail("Shouldn't get an AttributeError due to undefined 500 handler")
|
||||
|
||||
|
||||
class NoRootUrlConfTests(TestCase):
|
||||
"""Tests for handler404 and handler500 if urlconf is None"""
|
||||
urls = None
|
||||
|
@ -596,6 +603,7 @@ class NoRootUrlConfTests(TestCase):
|
|||
def test_no_handler_exception(self):
|
||||
self.assertRaises(ImproperlyConfigured, self.client.get, '/test/me/')
|
||||
|
||||
|
||||
class ResolverMatchTests(TestCase):
|
||||
urls = 'urlpatterns_reverse.namespace_urls'
|
||||
|
||||
|
@ -631,6 +639,7 @@ class ResolverMatchTests(TestCase):
|
|||
request = HttpRequest()
|
||||
self.assertIsNone(request.resolver_match)
|
||||
|
||||
|
||||
class ErroneousViewTests(TestCase):
|
||||
urls = 'urlpatterns_reverse.erroneous_urls'
|
||||
|
||||
|
@ -650,6 +659,7 @@ class ErroneousViewTests(TestCase):
|
|||
# The regex error will be hit before NoReverseMatch can be raised
|
||||
self.assertRaises(ImproperlyConfigured, reverse, 'whatever blah blah')
|
||||
|
||||
|
||||
class ViewLoadingTests(TestCase):
|
||||
def test_view_loading(self):
|
||||
# A missing view (identified by an AttributeError) should raise
|
||||
|
|
|
@ -2,6 +2,7 @@ from django.conf.urls import patterns, url
|
|||
from django.template import Template, Context
|
||||
from django.http import HttpResponse
|
||||
|
||||
|
||||
def inner_view(request):
|
||||
content = Template('{% url "outer" as outer_url %}outer:{{ outer_url }},'
|
||||
'{% url "inner" as inner_url %}inner:{{ inner_url }}').render(Context())
|
||||
|
|
|
@ -4,21 +4,27 @@ from django.core.urlresolvers import reverse_lazy
|
|||
|
||||
from django.contrib.auth.decorators import user_passes_test
|
||||
|
||||
|
||||
def empty_view(request, *args, **kwargs):
|
||||
return HttpResponse('')
|
||||
|
||||
|
||||
def kwargs_view(request, arg1=1, arg2=2):
|
||||
return HttpResponse('')
|
||||
|
||||
|
||||
def absolute_kwargs_view(request, arg1=1, arg2=2):
|
||||
return HttpResponse('')
|
||||
|
||||
|
||||
def defaults_view(request, arg1, arg2):
|
||||
pass
|
||||
|
||||
|
||||
def erroneous_view(request):
|
||||
import non_existent # NOQA
|
||||
|
||||
|
||||
def pass_resolver_match_view(request, *args, **kwargs):
|
||||
response = HttpResponse('')
|
||||
response.resolver_match = request.resolver_match
|
||||
|
@ -26,18 +32,22 @@ def pass_resolver_match_view(request, *args, **kwargs):
|
|||
|
||||
uncallable = "Can I be a view? Pleeeease?"
|
||||
|
||||
|
||||
class ViewClass(object):
|
||||
def __call__(self, request, *args, **kwargs):
|
||||
return HttpResponse('')
|
||||
|
||||
view_class_instance = ViewClass()
|
||||
|
||||
|
||||
class LazyRedirectView(RedirectView):
|
||||
url = reverse_lazy('named-lazy-url-redirected-to')
|
||||
|
||||
|
||||
@user_passes_test(lambda u: u.is_authenticated(), login_url=reverse_lazy('some-login-page'))
|
||||
def login_required_view(request):
|
||||
return HttpResponse('Hello you')
|
||||
|
||||
|
||||
def bad_view(request, *args, **kwargs):
|
||||
raise ValueError("I don't think I'm getting good value for this view")
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue