mirror of
https://github.com/django/django.git
synced 2025-08-04 02:48:35 +00:00
Fixed #26011 -- Prevented random LiveServerTestCase test failures on Windows.
Prevented LiveServerTestCase from stealing ports used by concurrent processes on Windows.
This commit is contained in:
parent
89616f0c79
commit
c87540cee5
3 changed files with 31 additions and 1 deletions
|
@ -5,6 +5,7 @@ Tests for django.core.servers.
|
|||
from __future__ import unicode_literals
|
||||
|
||||
import contextlib
|
||||
import errno
|
||||
import os
|
||||
import socket
|
||||
|
||||
|
@ -174,3 +175,31 @@ class LiveServerDatabase(LiveServerBase):
|
|||
['jane', 'robert', 'emily'],
|
||||
lambda b: b.name
|
||||
)
|
||||
|
||||
|
||||
class LiveServerPort(LiveServerBase):
|
||||
|
||||
def test_port_bind(self):
|
||||
"""
|
||||
Each LiveServerTestCase binds to a unique port or fails to start a
|
||||
server thread when run concurrently (#26011).
|
||||
"""
|
||||
TestCase = type(str("TestCase"), (LiveServerBase,), {})
|
||||
try:
|
||||
TestCase.setUpClass()
|
||||
except socket.error as e:
|
||||
if e.ernrno == errno.EADDRINUSE:
|
||||
# We're out of ports, LiveServerTestCase correctly fails with
|
||||
# a socket error.
|
||||
return
|
||||
# Unexpected error.
|
||||
raise
|
||||
try:
|
||||
# We've acquired a port, ensure our server threads acquired
|
||||
# different addresses.
|
||||
self.assertNotEqual(
|
||||
self.live_server_url, TestCase.live_server_url,
|
||||
"Acquired duplicate server addresses for server threads: %s" % self.live_server_url
|
||||
)
|
||||
finally:
|
||||
TestCase.tearDownClass()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue