mirror of
https://github.com/django/django.git
synced 2025-11-29 23:11:33 +00:00
Subquery deconstruction support required implementing complex and
expensive equality rules for sql.Query objects for little benefit as
the latter cannot themselves be made deconstructible to their reference
to model classes.
Making Expression @deconstructible and not BaseExpression allows
interested parties to conform to the "expression" API even if they are
not deconstructible as it's only a requirement for expressions allowed
in Model fields and meta options (e.g. constraints, indexes).
Thanks Phillip Cutter for the report.
This also fixes a performance regression in bbf141bcdc.
This commit is contained in:
parent
4f600673d7
commit
c8b6594305
6 changed files with 31 additions and 65 deletions
|
|
@ -36,7 +36,6 @@ from django.db.models.sql.where import (
|
|||
AND, OR, ExtraWhere, NothingNode, WhereNode,
|
||||
)
|
||||
from django.utils.functional import cached_property
|
||||
from django.utils.hashable import make_hashable
|
||||
from django.utils.tree import Node
|
||||
|
||||
__all__ = ['Query', 'RawQuery']
|
||||
|
|
@ -250,14 +249,6 @@ class Query(BaseExpression):
|
|||
for alias in self.alias_map:
|
||||
return alias
|
||||
|
||||
@property
|
||||
def identity(self):
|
||||
identity = (
|
||||
(arg, make_hashable(value))
|
||||
for arg, value in self.__dict__.items()
|
||||
)
|
||||
return (self.__class__, *identity)
|
||||
|
||||
def __str__(self):
|
||||
"""
|
||||
Return the query as a string of SQL with the parameter values
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue