mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-24 12:34:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Refs #25367 -- Simplified OrderBy and Lookup by using Case() instead of RawSQL() on Oracle.

Browse source 
Follow up to efa1908f66.
This commit is contained in:
Mariusz Felisiak 2019-08-29 11:56:12 +02:00 • committed by GitHub
parent 4137fc2efc
commit d275fd04f3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
django/db/models/expressions.py
View file

@ -1163,11 +1163,11 @@ class OrderBy(BaseExpression):
# a CASE WHEN.
if isinstance(self.expression, Exists):
copy = self.copy()
# XXX: Use Case(When(self.lhs)) once support for boolean
# expressions is added to When.
exists_sql, params = compiler.compile(self.expression)
case_sql = 'CASE WHEN %s THEN 1 ELSE 0 END' % exists_sql
copy.expression = RawSQL(case_sql, params)
copy.expression = Case(
When(self.expression, then=True),
default=False,
output_field=fields.BooleanField(),
)
return copy.as_sql(compiler, connection)
return self.as_sql(compiler, connection)