mirror of
https://github.com/django/django.git
synced 2025-08-04 10:59:45 +00:00
Fixed #18461 -- Ensured that last_executed_query returns Unicode
Thanks Anssi Kääriäinen for the review.
This commit is contained in:
parent
a7ef802fa4
commit
e9ef9776d1
3 changed files with 19 additions and 11 deletions
|
@ -125,20 +125,14 @@ class DateQuotingTest(TestCase):
|
|||
classes = models.SchoolClass.objects.filter(last_updated__day=20)
|
||||
self.assertEqual(len(classes), 1)
|
||||
|
||||
|
||||
class LastExecutedQueryTest(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
# connection.queries will not be filled in without this
|
||||
settings.DEBUG = True
|
||||
|
||||
def tearDown(self):
|
||||
settings.DEBUG = False
|
||||
|
||||
# There are no tests for the sqlite backend because it does not
|
||||
# There are no escaping tests for the sqlite backend because it does not
|
||||
# implement paramater escaping. See #14091.
|
||||
|
||||
@unittest.skipUnless(connection.vendor in ('oracle', 'postgresql'),
|
||||
"These backends use the standard parameter escaping rules")
|
||||
@override_settings(DEBUG=True)
|
||||
def test_parameter_escaping(self):
|
||||
# check that both numbers and string are properly quoted
|
||||
list(models.Tag.objects.filter(name="special:\\\"':", object_id=12))
|
||||
|
@ -148,6 +142,7 @@ class LastExecutedQueryTest(TestCase):
|
|||
|
||||
@unittest.skipUnless(connection.vendor == 'mysql',
|
||||
"MySQL uses backslashes to escape parameters.")
|
||||
@override_settings(DEBUG=True)
|
||||
def test_parameter_escaping(self):
|
||||
list(models.Tag.objects.filter(name="special:\\\"':", object_id=12))
|
||||
sql = connection.queries[-1]['sql']
|
||||
|
@ -155,6 +150,17 @@ class LastExecutedQueryTest(TestCase):
|
|||
self.assertTrue("= 'special:\\\\\\\"\\':' " in sql)
|
||||
self.assertTrue("= 12 " in sql)
|
||||
|
||||
def test_query_encoding(self):
|
||||
"""
|
||||
Test that last_executed_query() returns an Unicode string
|
||||
"""
|
||||
tags = models.Tag.objects.filter(name="й", object_id=12).extra(select={'föö':1})
|
||||
sql, params = tags.query.sql_with_params()
|
||||
cursor = tags.query.get_compiler('default').execute_sql(None)
|
||||
last_sql = cursor.db.ops.last_executed_query(cursor, sql, params)
|
||||
self.assertTrue(isinstance(last_sql, unicode))
|
||||
|
||||
|
||||
class ParameterHandlingTest(TestCase):
|
||||
def test_bad_parameter_count(self):
|
||||
"An executemany call with too many/not enough parameters will raise an exception (Refs #12612)"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue