mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-02 21:03:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #14873 -- A paginated ListView with a List instead of queryset produces an error.

Browse source 
Additional minor change in functionality: the page is now not considered paginated if the objects do not span multiple pages according to the paginator. This will only affect views with a custom paginator method which uses orphans.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14864 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Chris Beaven 2010-12-09 02:34:14 +00:00
parent b37d867929
commit ff8711a825
4 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/regressiontests/generic_views/list.py
View file

@ -90,7 +90,7 @@ class ListViewTests(TestCase):
self._make_authors(7)
res = self.client.get('/list/authors/paginated/custom_class/')
self.assertEqual(res.status_code, 200)
self.assertIsInstance(res.context['paginator'], CustomPaginator)
self.assertIsNone(res.context['paginator'])
# Custom pagination allows for 2 orphans on a page size of 5
self.assertEqual(len(res.context['object_list']), 7)
@ -101,6 +101,11 @@ class ListViewTests(TestCase):
# Custom pagination allows for 2 orphans on a page size of 5
self.assertEqual(len(res.context['object_list']), 7)
def test_paginated_non_queryset(self):
res = self.client.get('/list/dict/paginated/')
self.assertEqual(res.status_code, 200)
self.assertEqual(len(res.context['object_list']), 1)
def test_allow_empty_false(self):
res = self.client.get('/list/authors/notempty/')
self.assertEqual(res.status_code, 200)