mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-06 03:48:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
31009 commits 29 branches 451 tags 695 MiB
Commit graph

102 commits

Author SHA1 Message Date
Simon Charette
b3db6c8dcb Fixed #21204 -- Tracked field deferrals by field instead of models. 
This ensures field deferral works properly when a model is involved
more than once in the same query with a distinct deferral mask.
 2022-08-30 08:43:53 +02:00
Simon Charette
60613ef516 Merged nested if statements in select_related_descend(). 2022-08-30 06:59:55 +02:00
Nick Pope
845667f2d1 Refs #32948 -- Simplified and optimized Q._combine() and __invert__(). 
- Removed use of Q.deconstruct() in Q._combine().
- Simplified and optimized Q.__invert__() by taking a shallow copy and
  swapping the negated attribute only.
- Simplified construction in Q._combine().
- Simplified conditions in Q._combine() as Q.conditional = True the
  first isinstance() check is unnecessary.
- Removed copy.copy() branch in Q._combine().

Co-authored-by: Keryn Knight <keryn@kerynknight.com>
 2022-07-27 10:06:24 +02:00
Gagaro
5d91dc8ee3 Refs #30581 -- Added Q.check() hook. 2022-05-04 08:47:52 +02:00
Gagaro
9d04711261 Refs #30581 -- Added Q.flatten(). 2022-05-03 15:31:53 +02:00
Himanshu-Balasamanta
06ebaa9e28 Fixed #33626 -- Cleared cache when unregistering a lookup. 2022-04-12 06:24:02 +02:00
Mariusz Felisiak
0db0a25d84
Updated select_related_descend() comment. 
Outdated since 0c7633178f.
 2022-03-31 08:50:25 +02:00
Ryan Heard
c6b4d62fa2 Fixed #29865 -- Added logical XOR support for Q() and querysets. 2022-03-04 12:55:37 +01:00
django-bot
9c19aff7c7 Refs #33476 -- Reformatted code with Black. 2022-02-07 20:37:05 +01:00
Simon Charette
c8b6594305 Fixed #32632, Fixed #32657 -- Removed flawed support for Subquery deconstruction. 
Subquery deconstruction support required implementing complex and
expensive equality rules for sql.Query objects for little benefit as
the latter cannot themselves be made deconstructible to their reference
to model classes.

Making Expression @deconstructible and not BaseExpression allows
interested parties to conform to the "expression" API even if they are
not deconstructible as it's only a requirement for expressions allowed
in Model fields and meta options (e.g. constraints, indexes).

Thanks Phillip Cutter for the report.

This also fixes a performance regression in bbf141bcdc.
 2021-04-28 12:13:55 +02:00
Jonathan Richards
00b0786de5 Fixed #32548 -- Fixed crash when combining Q() objects with boolean expressions. 2021-03-17 21:53:39 +01:00
Hasan Ramezani
f2bef2b7bc Fixed #32455 -- Allowed right combining Q() with boolean expressions. 2021-02-18 22:20:36 +01:00
starryrbs
466920f6d7 Fixed #32450 -- Fixed crash when ANDing/ORing an empty Q() with not pickleable Q(). 
Regression in bb0b6e5263.
 2021-02-18 21:13:24 +01:00
Mariusz Felisiak
68e3ca13d7 Refs #30988 -- Removed InvalidQuery exception per deprecation timeline. 2021-01-14 17:50:04 +01:00
alosultan
678c8dfee4 Fixed #31680 -- Removed unnecessary getattr() call in DeferredAttribute.__get__(). 
refresh_from_db() loads fields values.
 2020-06-10 12:24:18 +02:00
Taoup
efc1c73bf5
Simplified DeferredAttribute.__get__() a bit. 2020-01-29 16:06:56 +01:00
Alex Aktsipetrov
bf12273db4 Fixed #31060 -- Reallowed window expressions to be used in conditions outside of queryset filters. 
Regression in 4edad1ddf6.

Thanks utapyngo for the report.
 2019-12-06 13:52:16 +01:00
Simon Charette
11e327a3ff Fixed #30988 -- Deprecated the InvalidQuery exception. 
It was barely documented without pointers at its defining location and
was abused to prevent misuse of the QuerySet field deferring feature.
 2019-11-18 14:06:51 +01:00
Simon Charette
3ca77e2b84 Replaced QueryWrapper single usage with RawSQL. 2019-11-18 10:45:24 +01:00
ElizabethU
54ea290e5b Fixed #30651 -- Made __eq__() methods return NotImplemented for not implemented comparisons. 
Changed __eq__ to return NotImplemented instead of False if compared to
an object of the same type, as is recommended by the Python data model
reference. Now these models can be compared to ANY (or other objects
with __eq__ overwritten) without returning False automatically.
 2019-10-01 17:58:19 +02:00
Jon Dufresne
93ffa81bc5 Refs #30657 -- Made DeferredAttribute.__init__() to take a field instance instead of a field name. 2019-07-25 07:24:52 +02:00
David Beitey
8bdb12c1d3 Fixed typo in django/db/models/query_utils.py comment. 2019-04-03 08:18:54 +02:00
Jon Dufresne
1e87c9fe71 Replaced kwargs.pop() with keyword-only arguments. 2018-10-08 15:06:02 -04:00
Sergey Fedoseev
8ef8bc0f64 Refs #28909 -- Simplifed code using unpacking generalizations. 2018-09-28 09:57:12 -04:00
Tim Graham
9ba3df8240 Refs #29125 -- Made Q.deconstruct() omit 'query_utils' in the path and _connector='AND' since it's a default value. 2018-02-12 15:23:41 -05:00
Tim Graham
b95c49c954 Fixed #29125 -- Made Q.deconstruct() deterministic with multiple keyword arguments. 2018-02-12 14:52:32 -05:00
Mariusz Felisiak
c86e9b5847 Removed DeferredAttribute.__init__()'s unused model argument. 
Unused since a8a81aae20.
 2018-01-02 17:54:10 -05:00
Simon Charette
b43acf22df Refs #27849 -- Removed empty Q() hack in filtered Aggregate.as_sql(). 
This required allowing WhereNode to be provided as When(condition).

This was made possible by cf12257db2.
 2017-12-08 10:59:49 -05:00
Nicolas Delaby
01d440fa1e Fixed #27332 -- Added FilteredRelation API for conditional join (ON clause) support. 
Thanks Anssi Kääriäinen for contributing to the patch.
 2017-09-22 11:53:17 -04:00
Sergey Fedoseev
99e7bba443 Prevented query_utils.refs_expression() from looking for empty string in annotations map. 2017-07-28 08:42:52 -04:00
Tom
bb0b6e5263 Fixed #28211 -- Prevented ORing an empty Q() from reducing query join efficiency. 2017-05-25 09:06:25 -04:00
Anton Samarchyan
60e52a047e Refs #27656 -- Updated django.db docstring verbs according to PEP 257. 2017-02-28 09:17:27 -05:00
Ian Foote
508b5debfb Refs #11964 -- Made Q objects deconstructible. 2017-02-23 20:47:48 -05:00
chillaranand
d6eaf7c018 Refs #23919 -- Replaced super(ClassName, self) with super(). 2017-01-25 12:23:46 -05:00
Tim Graham
d170c63351 Refs #23919 -- Removed misc references to Python 2. 2017-01-21 20:02:00 -05:00
Simon Charette
cecc079168 Refs #23919 -- Stopped inheriting from object to define new style classes. 2017-01-19 08:39:46 +01:00
Aymeric Augustin
3cc5f01d9b Refs #23919 -- Stopped using django.utils.lru_cache(). 2017-01-18 21:42:40 -05:00
Claude Paroz
d7b9aaa366 Refs #23919 -- Removed encoding preambles and future imports 2017-01-18 09:55:19 +01:00
Tim Graham
c47f8a9d4d Removed obsolete lines in DeferredAttribute.__get__(). 
Obsolete as of c21e86ab9e.
 2016-09-26 18:47:07 -04:00
Ryan P Kilby
7aeb7390fc Fixed #26891 -- Fixed lookup registration for ForeignObject. 2016-08-11 14:16:48 -04:00
Anssi Kääriäinen
7f51876f99 Fixed #26207 -- Replaced dynamic classes with non-data descriptors for deferred instance loading. 2016-04-29 13:06:32 -04:00
Tim Graham
b454e2cbc9 Removed unused Q.clone(). 
Unused since afe0bb7b13.
 2016-04-25 08:31:32 -04:00
Tim Graham
a755e0657e Removed unused BaseExpression.refs_aggregate(). 
Unused since afe0bb7b13.
 2016-04-22 13:04:13 -04:00
Tim Graham
0456a8b9e6 Fixed #26486 -- Fixed a select_related() + defer() MTI edge case. 2016-04-13 10:32:17 -04:00
Tim Graham
70d3f81ca4 Fixed #26233 -- Fixed invalid reSt in models.Q docstring. 2016-02-18 08:45:55 -05:00
Tim Graham
0b5d32faca Fixed #25611 -- Standardized descriptor signatures. 2015-10-26 11:31:16 -04:00
Simon Charette
3db3ab71e9 Fixed #25563 -- Cached deferred models in their proxied model's _meta.apps. 
Thanks to Andriy Sokolovskiy for the report and Tim Graham for the review.
 2015-10-19 20:11:32 -04:00
Tim Graham
ea8e7fd989 Removed obsolete (since Python 2.3) __safe_for_unpickling__ attribute. 2015-10-05 08:07:27 -04:00
Josh Smeaton
534aaf56f4 Fixed #24629 -- Unified Transform and Expression APIs 2015-09-21 19:56:24 +10:00
Anssi Kääriäinen
9ed82154bd Fixed #23791 -- Corrected object type check for pk__in=qs 
When the pk was a relation field, qs.filter(pk__in=qs) didn't work.

In addition, fixed Restaurant.objects.filter(place=restaurant_instance),
where place is an OneToOneField and the primary key of Restaurant.

A big thank you to Josh for review and to Tim for review and cosmetic
edits.

Thanks to Beauhurst for commissioning the work on this ticket.
 2015-06-29 07:49:31 -04:00