mirror of
https://github.com/django/django.git
synced 2025-08-04 10:59:45 +00:00

Added postgres.E005 to validate 'django.contrib.postgres' is in INSTALLED_APPS when using: * PostgreSQL-specific fields (ArrayField, HStoreField, range fields, SearchVectorField), * PostgreSQL indexes (PostgresIndex and all subclasses), and * ExclusionConstraint The check provides immediate feedback during system checks rather than failing later with obscure runtime and database errors. Thanks to Simon Charette and Sarah Boyce for reviews.
146 lines
5.6 KiB
Python
146 lines
5.6 KiB
Python
from unittest import skipUnless
|
|
|
|
from django.core import checks
|
|
from django.db import connection, models
|
|
from django.test import SimpleTestCase
|
|
from django.test.utils import isolate_apps, modify_settings
|
|
|
|
|
|
@isolate_apps("invalid_models_tests")
|
|
class DeprecatedFieldsTests(SimpleTestCase):
|
|
def test_IPAddressField_deprecated(self):
|
|
class IPAddressModel(models.Model):
|
|
ip = models.IPAddressField()
|
|
|
|
model = IPAddressModel()
|
|
self.assertEqual(
|
|
model.check(),
|
|
[
|
|
checks.Error(
|
|
"IPAddressField has been removed except for support in "
|
|
"historical migrations.",
|
|
hint="Use GenericIPAddressField instead.",
|
|
obj=IPAddressModel._meta.get_field("ip"),
|
|
id="fields.E900",
|
|
)
|
|
],
|
|
)
|
|
|
|
def test_CommaSeparatedIntegerField_deprecated(self):
|
|
class CommaSeparatedIntegerModel(models.Model):
|
|
csi = models.CommaSeparatedIntegerField(max_length=64)
|
|
|
|
model = CommaSeparatedIntegerModel()
|
|
self.assertEqual(
|
|
model.check(),
|
|
[
|
|
checks.Error(
|
|
"CommaSeparatedIntegerField is removed except for support in "
|
|
"historical migrations.",
|
|
hint=(
|
|
"Use "
|
|
"CharField(validators=[validate_comma_separated_integer_list]) "
|
|
"instead."
|
|
),
|
|
obj=CommaSeparatedIntegerModel._meta.get_field("csi"),
|
|
id="fields.E901",
|
|
)
|
|
],
|
|
)
|
|
|
|
def test_nullbooleanfield_deprecated(self):
|
|
class NullBooleanFieldModel(models.Model):
|
|
nb = models.NullBooleanField()
|
|
|
|
model = NullBooleanFieldModel()
|
|
self.assertEqual(
|
|
model.check(),
|
|
[
|
|
checks.Error(
|
|
"NullBooleanField is removed except for support in historical "
|
|
"migrations.",
|
|
hint="Use BooleanField(null=True, blank=True) instead.",
|
|
obj=NullBooleanFieldModel._meta.get_field("nb"),
|
|
id="fields.E903",
|
|
),
|
|
],
|
|
)
|
|
|
|
@skipUnless(connection.vendor == "postgresql", "PostgreSQL specific SQL")
|
|
def test_postgres_jsonfield_deprecated(self):
|
|
from django.contrib.postgres.fields import JSONField
|
|
|
|
class PostgresJSONFieldModel(models.Model):
|
|
field = JSONField()
|
|
|
|
self.assertEqual(
|
|
PostgresJSONFieldModel.check(),
|
|
[
|
|
checks.Error(
|
|
"django.contrib.postgres.fields.JSONField is removed except "
|
|
"for support in historical migrations.",
|
|
hint="Use django.db.models.JSONField instead.",
|
|
obj=PostgresJSONFieldModel._meta.get_field("field"),
|
|
id="fields.E904",
|
|
),
|
|
],
|
|
)
|
|
|
|
@skipUnless(connection.vendor == "postgresql", "PostgreSQL specific SQL")
|
|
@modify_settings(INSTALLED_APPS={"append": "django.contrib.postgres"})
|
|
def test_postgres_ci_fields_deprecated(self):
|
|
from django.contrib.postgres.fields import (
|
|
ArrayField,
|
|
CICharField,
|
|
CIEmailField,
|
|
CITextField,
|
|
)
|
|
|
|
class PostgresCIFieldsModel(models.Model):
|
|
ci_char = CICharField(max_length=255)
|
|
ci_email = CIEmailField()
|
|
ci_text = CITextField()
|
|
array_ci_text = ArrayField(CITextField())
|
|
|
|
self.assertEqual(
|
|
PostgresCIFieldsModel.check(),
|
|
[
|
|
checks.Error(
|
|
"django.contrib.postgres.fields.CICharField is removed except for "
|
|
"support in historical migrations.",
|
|
hint=(
|
|
'Use CharField(db_collation="…") with a case-insensitive '
|
|
"non-deterministic collation instead."
|
|
),
|
|
obj=PostgresCIFieldsModel._meta.get_field("ci_char"),
|
|
id="fields.E905",
|
|
),
|
|
checks.Error(
|
|
"django.contrib.postgres.fields.CIEmailField is removed except for "
|
|
"support in historical migrations.",
|
|
hint=(
|
|
'Use EmailField(db_collation="…") with a case-insensitive '
|
|
"non-deterministic collation instead."
|
|
),
|
|
obj=PostgresCIFieldsModel._meta.get_field("ci_email"),
|
|
id="fields.E906",
|
|
),
|
|
checks.Error(
|
|
"django.contrib.postgres.fields.CITextField is removed except for "
|
|
"support in historical migrations.",
|
|
hint=(
|
|
'Use TextField(db_collation="…") with a case-insensitive '
|
|
"non-deterministic collation instead."
|
|
),
|
|
obj=PostgresCIFieldsModel._meta.get_field("ci_text"),
|
|
id="fields.E907",
|
|
),
|
|
checks.Error(
|
|
"Base field for array has errors:\n"
|
|
" django.contrib.postgres.fields.CITextField is removed except "
|
|
"for support in historical migrations. (fields.E907)",
|
|
obj=PostgresCIFieldsModel._meta.get_field("array_ci_text"),
|
|
id="postgres.E001",
|
|
),
|
|
],
|
|
)
|