2 commits

Author	SHA1	Message	Date
Andrew Gallant	b8757deba8	error: switch everything over to structured errors ... This was an incredibly tedious and tortuous refactor. But this removes almost all of the "create ad hoc stringly-typed errors everywhere." This partially makes progress toward #418, but my initial impetus for doing this was to see if I could reduce binary size and improve compilation times. My general target was to see if I could reduce total LLVM lines. I tested this with [Biff] using this command in the root of the Biff repo: ``` cargo llvm-lines --profile release-lto ``` Before this change, Biff had 768,596 LLVM lines. With this change, it has 757,331 lines. So... an improvement, but a very modest one. What about compilation times? This does seem to translate to---also a modest---improvement. For compiling release builds of Biff. Before: ``` $ hyperfine -w1 --prepare 'cargo clean' 'cargo b -r' Benchmark 1: cargo b -r Time (mean ± σ): 7.776 s ± 0.052 s [User: 65.876 s, System: 2.621 s] Range (min … max): 7.690 s … 7.862 s 10 runs ``` After: ``` $ hyperfine -w1 --prepare 'cargo clean' 'cargo b -r' Benchmark 1: cargo b -r Time (mean ± σ): 7.591 s ± 0.067 s [User: 65.686 s, System: 2.564 s] Range (min … max): 7.504 s … 7.689 s 10 runs ``` What about dev builds? Before: ``` $ hyperfine -w1 --prepare 'cargo clean' 'cargo b' Benchmark 1: cargo b Time (mean ± σ): 4.074 s ± 0.022 s [User: 14.493 s, System: 1.818 s] Range (min … max): 4.037 s … 4.099 s 10 runs ``` After: ``` $ hyperfine -w1 --prepare 'cargo clean' 'cargo b' Benchmark 1: cargo b Time (mean ± σ): 4.541 s ± 0.027 s [User: 15.385 s, System: 2.081 s] Range (min … max): 4.503 s … 4.591 s 10 runs ``` Well... that's disappointing. A modest improvement to release builds, but a fairly large regression in dev builds. Maybe it's because of the additional hand-written impls for new structured error types? Bah. And binary size? Normal release builds (not LTO) of Biff that were stripped were 4,431,456 bytes before this change and 4,392,064 after. Hopefully this will unlock other improvements to justify doing this. Note also that this slims down a number of error messages. [Biff]: https://github.com/BurntSushi/biff	2025-12-16 16:51:01 -05:00
Andrew Gallant	08abeadd09	tz: fallback to Etc/Unknown when TZ is set to an invalid value ... Previously, when `TZ` was set to an invalid value, Jiff would still attempt to detect the system configured time zone. But this is arguably not great, because it silently (aside from logs) rejects an invalid `TZ` value. In reality, if `TZ` is set, it is likely that the user intends for it to have an impact. So if it doesn't, we should bleat about it. This manifests as an error when using `TimeZone::try_system()` and manifests as a error sentinel in the form of `Etc/Unknown` when using `TimeZone::system()`. We also tweak some of the logging levels. Namely, in #370, I increased the number of TRACE-level log messages, which makes it much noisier. So I've promoted a few things that were TRACE to DEBUG without making the output much noisier. I guess TRACE should be reserved for variable length things. Fixes #364	2025-05-17 11:02:57 -04:00