mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-08-04 18:18:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

rollback transaction when we fail in step

Browse source
This commit is contained in:
pedrocarlo 2025-07-03 16:35:37 -03:00
parent 897426a662
commit 9632ab0a41
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/storage/sqlite3_ondisk.rs
View file

@ -1569,8 +1569,8 @@ pub fn begin_write_wal_frame(
if res.is_err() {
// If we do not reduce the counter here on error, we incur an infinite loop when cacheflushing
*write_counter.borrow_mut() -= 1;
res?;
}
res?;
tracing::trace!("Frame written and synced");
Ok(checksums)
}

8
core/vdbe/mod.rs
View file

@ -382,8 +382,12 @@ impl Program {
let _ = state.result_row.take();
let (insn, insn_function) = &self.insns[state.pc as usize];
trace_insn(self, state.pc as InsnReference, insn);
let res = insn_function(self, state, insn, &pager, mv_store.as_ref())?;
match res {
let res = insn_function(self, state, insn, &pager, mv_store.as_ref());
if res.is_err() {
// TODO: see change_schema correct value
pager.rollback(false, &self.connection)?
}
match res? {
InsnFunctionStepResult::Step => {}
InsnFunctionStepResult::Done => return Ok(StepResult::Done),
InsnFunctionStepResult::IO => return Ok(StepResult::IO),