mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-07-07 20:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

extensions/time: normalize offset_sec

Browse source
This commit is contained in:
meteorgan 2025-02-19 21:22:34 +08:00
parent 8ac09b73bf
commit 97337614db
3 changed files with 55 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

4
COMPAT.md
View file

@ -647,9 +647,9 @@ The `time` extension is compatible with [sqlean-time](https://github.com/nalgeon
| Function | Status | Comment |
| ------------------------------------------------------------------- | ------ | ---------------------------- |
| ------------------------------------------------------------------- | ------ |---------|
| time_now() | Yes | |
| time_date(year, month, day[, hour, min, sec[, nsec[, offset_sec]]]) | Yes | offset_sec is not normalized |
| time_date(year, month, day[, hour, min, sec[, nsec[, offset_sec]]]) | Yes | |
| time_get_year(t) | Yes | |
| time_get_month(t) | Yes | |
| time_get_day(t) | Yes | |

7
extensions/time/src/lib.rs
View file

@ -171,7 +171,6 @@ fn time_date_internal(args: &[Value]) -> Value {
let mut minutes = 0;
let mut seconds = 0;
let mut nano_secs = 0;
let mut offset = FixedOffset::east_opt(0).unwrap();
if args.len() >= 6 {
hour = ok_tri!(args[3].to_integer());
@ -185,9 +184,7 @@ fn time_date_internal(args: &[Value]) -> Value {
if args.len() == 8 {
let offset_sec = ok_tri!(args[7].to_integer()) as i32;
// TODO offset is not normalized. Maybe could just increase/decrease the number of seconds
// instead of relying in this offset
offset = ok_tri!(FixedOffset::east_opt(offset_sec));
seconds -= offset_sec as i64;
}
let t = Time::time_date(
@ -198,7 +195,7 @@ fn time_date_internal(args: &[Value]) -> Value {
minutes,
seconds,
nano_secs,
offset,
FixedOffset::east_opt(0).unwrap(),
);
let t = tri!(t);

4
testing/time.test
View file

@ -9,12 +9,16 @@ do_execsql_test time_date {
SELECT time_fmt_iso(time_date(2011, 11, 18, 15, 56, 35, 666777888));
SELECT time_fmt_iso(time_date(2011, 11, 18, 15, 56, 35, 0, 3*3600));
SELECT time_fmt_iso(time_date(2011, 11, 18, 15, 56, 35, 666777888, 3*3600));
SELECT time_fmt_iso(time_date(2011, 11, 18, 15, 56, 35, 666777888, 25*3600));
SELECT time_fmt_iso(time_date(2011, 11, 18, 15, 56, 35, 666777888, -25*3600));
} {
{2011-11-18T00:00:00Z}
{2011-11-18T15:56:35Z}
{2011-11-18T15:56:35.666777888Z}
{2011-11-18T12:56:35Z}
{2011-11-18T12:56:35.666777888Z}
{2011-11-17T14:56:35.666777888Z}
{2011-11-19T16:56:35.666777888Z}
}
do_execsql_test time_get_year {