mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-08-04 18:18:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Comment about tx visibility when deleting a row

Browse source
This commit is contained in:
Jussi Saurio 2025-02-08 11:18:05 +02:00
parent 40f59f124f
commit a0460ae2d5
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
core/mvcc/database/mod.rs
View file

@ -318,8 +318,9 @@ impl<Clock: LogicalClock, T: Sync + Send + Clone + Debug + 'static> MvStore<Cloc
.ok_or(DatabaseError::NoSuchTransactionID(tx_id))?;
let tx = tx.value().read().unwrap();
assert_eq!(tx.state, TransactionState::Active);
let version_is_visible_to_current_tx = is_version_visible(&self.txs, &tx, rv);
if !version_is_visible_to_current_tx {
// A transaction cannot delete a version that it cannot see,
// nor can it conflict with it.
if !is_version_visible(&self.txs, &tx, rv) {
continue;
}
if is_write_write_conflict(&self.txs, &tx, rv) {