mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-08-04 01:58:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix: init_limit() in wrong place for Delete

Browse source
This commit is contained in:
Jussi Saurio 2025-05-27 21:25:55 +03:00
parent 3c587b91b5
commit a9ae1af75c
1 changed files with 3 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
core/translate/emitter.rs
View file

@ -662,6 +662,8 @@ fn emit_program_for_delete(
return Ok(());
}
init_limit(program, &mut t_ctx, plan.limit, None);
// No rows will be read from source table loops if there is a constant false condition eg. WHERE 0
let after_main_loop_label = program.allocate_label();
t_ctx.label_main_loop_end = Some(after_main_loop_label);
@ -689,13 +691,7 @@ fn emit_program_for_delete(
&[JoinOrderMember::default()],
&mut plan.where_clause,
)?;
emit_delete_insns(
program,
&mut t_ctx,
&plan.table_references,
&plan.indexes,
&plan.limit,
)?;
emit_delete_insns(program, &mut t_ctx, &plan.table_references, &plan.indexes)?;
// Clean up and close the main execution loop
close_loop(
@ -718,7 +714,6 @@ fn emit_delete_insns(
t_ctx: &mut TranslateCtx,
table_references: &[TableReference],
index_references: &[Arc<Index>],
limit: &Option<isize>,
) -> Result<()> {
let table_reference = table_references.first().unwrap();
let cursor_id = match &table_reference.op {
@ -734,8 +729,6 @@ fn emit_delete_insns(
};
let main_table_cursor_id = program.resolve_cursor_id(table_reference.table.get_name());
init_limit(program, t_ctx, *limit, None);
// Emit the instructions to delete the row
let key_reg = program.alloc_register();
program.emit_insn(Insn::RowId {