mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-12-23 08:21:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge 'Fix is_nonnull returns true on 1 / 0' from Lâm Hoàng Phúc

Browse source 
turso:
```sh
turso> CREATE TABLE t (x PRIMARY KEY, y, z);
turso> INSERT INTO t VALUES (37, -70, -196792117);
turso> SELECT * FROM t WHERE  (1 / 0) >= -3289742039 < t.x;
┌────┬─────┬────────────┐
│ x  │ y   │ z          │
├────┼─────┼────────────┤
│ 37 │ -70 │ -196792117 │
└────┴─────┴────────────┘
turso>
```
sqlite:
```sh
sqlite> CREATE TABLE t (x PRIMARY KEY, y, z);
sqlite> INSERT INTO t VALUES (37, -70, -196792117);
sqlite> SELECT * FROM t WHERE  (1 / 0) >= -3289742039 < t.x;
sqlite>
```
related: 1776557140
/job/50488042583?pr=3147#step:8:855

Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com>
Reviewed-by: Preston Thorpe <preston@turso.tech>

Closes #3167
This commit is contained in:
Preston Thorpe 2025-09-17 06:55:55 -04:00 • committed by GitHub
commit bcafb288ad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
core/translate/optimizer/mod.rs
View file

@ -650,6 +650,7 @@ impl Optimizable for ast::Expr {
Expr::Between {
lhs, start, end, ..
} => lhs.is_nonnull(tables) && start.is_nonnull(tables) && end.is_nonnull(tables),
Expr::Binary(_, ast::Operator::Modulus | ast::Operator::Divide, _) => false, // 1 % 0, 1 / 0
Expr::Binary(expr, _, expr1) => expr.is_nonnull(tables) && expr1.is_nonnull(tables),
Expr::Case {
base,

6
testing/math.test
View file

@ -1445,3 +1445,9 @@ do_execsql_test unary-plus-noop-string {
do_execsql_test unary-plus-noop-blob {
SELECT typeof(+x'00') = 'blob'
} { 1 }
do_execsql_test_on_specific_db {:memory:} is-nonnull-divide-by-zero {
CREATE TABLE t (x PRIMARY KEY, y, z);
INSERT INTO t VALUES (37, -70, -196792117);
SELECT * FROM t WHERE (1 / 0) >= -3289742039 < t.x;
} {}