mirrors/limbo
1
0
Fork 0
mirror of https://github.com/tursodatabase/limbo.git synced 2025-08-04 18:18:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

invalidate records not necessary for fix

Browse source
This commit is contained in:
pedrocarlo 2025-05-18 12:54:15 -03:00
parent af1f9492ef
commit fd51c0a970
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
core/storage/btree.rs
View file

@ -3589,15 +3589,12 @@ impl BTreeCursor {
Some(rowid) => rowid,
None => {
self.state = CursorState::None;
// I don't think its necessary to invalidate here, but its safer to do so if I'm wrong
self.invalidate_record();
return Ok(CursorResult::Ok(()));
}
};
} else {
if self.reusable_immutable_record.borrow().is_none() {
self.state = CursorState::None;
// Record is None here so no need to invalidate
return Ok(CursorResult::Ok(()));
}
}
@ -3781,7 +3778,6 @@ impl BTreeCursor {
} else {
self.stack.retreat();
self.state = CursorState::None;
self.invalidate_record();
return Ok(CursorResult::Ok(()));
}
// Only reaches this function call if state = DeleteState::WaitForBalancingToComplete
@ -3838,18 +3834,12 @@ impl BTreeCursor {
return_if_io!(self.seek(key, SeekOp::EQ));
self.state = CursorState::None;
self.invalidate_record();
return Ok(CursorResult::Ok(()));
}
}
}
}
fn invalidate_record(&mut self) {
let mut record = self.get_immutable_record();
record.as_mut().map(|record| record.invalidate());
}
/// In outer joins, whenever the right-side table has no matching row, the query must still return a row
/// for each left-side row. In order to achieve this, we set the null flag on the right-side table cursor
/// so that it returns NULL for all columns until cleared.