mirrors/opencode
1
0
Fork 0
mirror of https://github.com/sst/opencode.git synced 2025-08-10 00:08:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

handle errors correctly in the other tools

Browse source
This commit is contained in:
Kujtim Hoxha 2025-04-14 11:24:36 +02:00
parent 921f5ee5bd
commit 0b3e5f5bd4
8 changed files with 72 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/llm/tools/view.go
View file

@ -135,7 +135,7 @@ func (v *viewTool) Run(ctx context.Context, call ToolCall) (ToolResponse, error)
return NewTextErrorResponse(fmt.Sprintf("File not found: %s", filePath)), nil
}
return NewTextErrorResponse(fmt.Sprintf("Failed to access file: %s", err)), nil
return ToolResponse{}, fmt.Errorf("error accessing file: %w", err)
}
// Check if it's a directory
@ -156,6 +156,7 @@ func (v *viewTool) Run(ctx context.Context, call ToolCall) (ToolResponse, error)
// Check if it's an image file
isImage, imageType := isImageFile(filePath)
// TODO: handle images
if isImage {
return NewTextErrorResponse(fmt.Sprintf("This is an image file of type: %s\nUse a different tool to process images", imageType)), nil
}
@ -163,7 +164,7 @@ func (v *viewTool) Run(ctx context.Context, call ToolCall) (ToolResponse, error)
// Read the file content
content, lineCount, err := readTextFile(filePath, params.Offset, params.Limit)
if err != nil {
return NewTextErrorResponse(fmt.Sprintf("Failed to read file: %s", err)), nil
return ToolResponse{}, fmt.Errorf("error reading file: %w", err)
}
notifyLspOpenFile(ctx, filePath, v.lspClients)