mirrors/pyright
1
0
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2025-12-23 09:19:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed regression that results in a false positive when using the pydantic.dataclasses.dataclass decorator. This addresses #11060. (#11084)
Some checks are pending
Run mypy_primer on push / Run mypy_primer on push (push) Waiting to run
Details
Validation / Typecheck (push) Waiting to run
Details
Validation / Style (push) Waiting to run
Details
Validation / Test macos-latest (push) Blocked by required conditions
Details
Validation / Test ubuntu-latest (push) Blocked by required conditions
Details
Validation / Test windows-latest (push) Blocked by required conditions
Details
Validation / Build (push) Blocked by required conditions
Details
Validation / Required (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Eric Traut 2025-11-01 20:05:36 -05:00 • committed by GitHub
parent 8d9df830e0
commit 89825e1c4e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
packages/pyright-internal/src/analyzer/decorators.ts
View file

@ -325,7 +325,7 @@ export function applyClassDecorator(
}
}
const applyDataclassTransform = (): void => {
const applyDataclassTransform = (): boolean => {
// Is this a dataclass decorator?
let dataclassBehaviors: DataClassBehaviors | undefined;
let callNode: CallNode | undefined;
@ -344,7 +344,10 @@ export function applyClassDecorator(
if (dataclassBehaviors) {
applyDataClassDecorator(evaluator, decoratorNode, originalClassType, dataclassBehaviors, callNode);
return true;
}
return false;
};
if (isOverloaded(decoratorType)) {
@ -383,14 +386,18 @@ export function applyClassDecorator(
return inputClassType;
}
applyDataclassTransform();
if (applyDataclassTransform()) {
return inputClassType;
}
} else if (isClassInstance(decoratorType)) {
if (ClassType.isBuiltIn(decoratorType, 'deprecated')) {
originalClassType.shared.deprecatedMessage = decoratorType.priv.deprecatedInstanceMessage;
return inputClassType;
}
applyDataclassTransform();
if (applyDataclassTransform()) {
return inputClassType;
}
}
return getTypeOfDecorator(evaluator, decoratorNode, inputClassType);