mirror of
https://github.com/ruuda/rcl.git
synced 2025-12-23 04:47:19 +00:00
7137cd5a91
Initially I used a comma after assertions, like Python. It was always a bit weird (even in Python), it's a statement but it has arguments. This made formatting akward too. I justified it for myself by saying "it's just a function call, but without the parens". That's how we currently format it. Then yesterday I was skimming through the Jsonnet docs, and they use a colon rather than comma, and that looks much more pleasant! I should steal the good ideas; if RCL can fix list comprehension order w.r.t Python, then it can also fix this one. For compatibility, accept the comma as well (for now), but make the formatter emit the colon. Similar to the colon after 'else', it does not have to be a breaking change. |
||
|---|---|---|
| .. | ||
| _input_fmt_err.rcl | ||
| _input_fmt_ok.rcl | ||
| format_check_changed.test | ||
| format_check_cli_changed.test | ||
| format_check_cli_unchanged.test | ||
| format_check_unchanged.test | ||
| highlight_html.test | ||
| patch_basic.test | ||
| patch_check_changed.test | ||
| patch_check_unchanged.test | ||
| patch_error_invalid_path.test | ||
| patch_error_invalid_replacement.test | ||
| patch_error_not_found_collection.test | ||
| patch_error_not_found_statements.test | ||
| patch_error_not_found_top_level.test | ||
| patch_let_expr.test | ||
| patch_let_seq.test | ||
| query_basic.test | ||