mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 06:11:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

C401 message missing closing parenthesis (#13498)

Browse source
This commit is contained in:
Simon Brugman 2024-09-24 14:55:32 +02:00 • committed by GitHub
parent ff4b6d11fa
commit 03503f7f56
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_linter/src/rules/flake8_comprehensions/rules/unnecessary_generator_set.rs
View file

@ -47,7 +47,7 @@ impl AlwaysFixableViolation for UnnecessaryGeneratorSet {
#[derive_message_formats] #[derive_message_formats]
fn message(&self) -> String { fn message(&self) -> String {
if self.short_circuit { if self.short_circuit {
format!("Unnecessary generator (rewrite using `set()`") format!("Unnecessary generator (rewrite using `set()`)")
} else { } else {
format!("Unnecessary generator (rewrite as a `set` comprehension)") format!("Unnecessary generator (rewrite as a `set` comprehension)")
} }

14
crates/ruff_linter/src/rules/flake8_comprehensions/snapshots/ruff_linter__rules__flake8_comprehensions__tests__C401_C401.py.snap
View file

@ -103,7 +103,7 @@ C401.py:12:17: C401 [*] Unnecessary generator (rewrite as a `set` comprehension)
14 14 | 14 14 |
15 15 | # Short-circuit case, combine with C416 and should produce x = set(range(3)) 15 15 | # Short-circuit case, combine with C416 and should produce x = set(range(3))
C401.py:16:5: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:16:5: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
15 | # Short-circuit case, combine with C416 and should produce x = set(range(3)) 15 | # Short-circuit case, combine with C416 and should produce x = set(range(3))
16 | x = set(x for x in range(3)) 16 | x = set(x for x in range(3))
@ -123,7 +123,7 @@ C401.py:16:5: C401 [*] Unnecessary generator (rewrite using `set()`
18 18 | x for x in range(3) 18 18 | x for x in range(3)
19 19 | ) 19 19 | )
C401.py:17:5: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:17:5: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
15 | # Short-circuit case, combine with C416 and should produce x = set(range(3)) 15 | # Short-circuit case, combine with C416 and should produce x = set(range(3))
16 | x = set(x for x in range(3)) 16 | x = set(x for x in range(3))
@ -149,7 +149,7 @@ C401.py:17:5: C401 [*] Unnecessary generator (rewrite using `set()`
21 19 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}") 21 19 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}")
22 20 | print(f"{ set(a for a in 'abc') - set(a for a in 'ab') }") 22 20 | print(f"{ set(a for a in 'abc') - set(a for a in 'ab') }")
C401.py:20:16: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:20:16: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
18 | x for x in range(3) 18 | x for x in range(3)
19 | ) 19 | )
@ -170,7 +170,7 @@ C401.py:20:16: C401 [*] Unnecessary generator (rewrite using `set()`
22 22 | print(f"{ set(a for a in 'abc') - set(a for a in 'ab') }") 22 22 | print(f"{ set(a for a in 'abc') - set(a for a in 'ab') }")
23 23 | 23 23 |
C401.py:21:10: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:21:10: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
19 | ) 19 | )
20 | print(f"Hello {set(a for a in range(3))} World") 20 | print(f"Hello {set(a for a in range(3))} World")
@ -190,7 +190,7 @@ C401.py:21:10: C401 [*] Unnecessary generator (rewrite using `set()`
23 23 | 23 23 |
24 24 | 24 24 |
C401.py:21:34: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:21:34: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
19 | ) 19 | )
20 | print(f"Hello {set(a for a in range(3))} World") 20 | print(f"Hello {set(a for a in range(3))} World")
@ -210,7 +210,7 @@ C401.py:21:34: C401 [*] Unnecessary generator (rewrite using `set()`
23 23 | 23 23 |
24 24 | 24 24 |
C401.py:22:11: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:22:11: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
20 | print(f"Hello {set(a for a in range(3))} World") 20 | print(f"Hello {set(a for a in range(3))} World")
21 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}") 21 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}")
@ -229,7 +229,7 @@ C401.py:22:11: C401 [*] Unnecessary generator (rewrite using `set()`
24 24 | 24 24 |
25 25 | # Not built-in set. 25 25 | # Not built-in set.
C401.py:22:35: C401 [*] Unnecessary generator (rewrite using `set()` C401.py:22:35: C401 [*] Unnecessary generator (rewrite using `set()`)
| |
20 | print(f"Hello {set(a for a in range(3))} World") 20 | print(f"Hello {set(a for a in range(3))} World")
21 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}") 21 | print(f"{set(a for a in 'abc') - set(a for a in 'ab')}")