mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-02 06:41:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Document literal-membership fix safety conditions (#9677)

Browse source 
## Summary

This seems safe to me. See
https://github.com/astral-sh/ruff/issues/8482#issuecomment-1859299411.

## Test Plan

`cargo test`
This commit is contained in:
Charlie Marsh 2024-01-29 09:48:40 -08:00 • committed by GitHub
parent a6f7100b55
commit 05a2f52206
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs
View file

@ -21,6 +21,12 @@ use crate::checkers::ast::Checker;
/// ```python /// ```python
/// 1 in {1, 2, 3} /// 1 in {1, 2, 3}
/// ``` /// ```
///
/// ## Fix safety
/// This rule's fix is marked as unsafe, as the use of a `set` literal will
/// error at runtime if the sequence contains unhashable elements (like lists
/// or dictionaries).
///
/// ## References /// ## References
/// - [What’s New In Python 3.2](https://docs.python.org/3/whatsnew/3.2.html#optimizations) /// - [What’s New In Python 3.2](https://docs.python.org/3/whatsnew/3.2.html#optimizations)
#[violation] #[violation]