mirror of
https://github.com/astral-sh/ruff.git
synced 2025-11-23 13:36:52 +00:00
[airflow] Extend airflow.models..Param check (AIR311) (#21043)
<!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> * Extend `airflow.models.Param` to include `airflow.models.param.Param` case and include both `airflow.models.param.ParamDict` and `airflow.models.param.DagParam` and their `airflow.models.` counter part ## Test Plan <!-- How was it tested? --> update the text fixture accordingly and reorganize them in the third commit
This commit is contained in:
parent
83a3bc4ee9
commit
05cde8bd19
3 changed files with 168 additions and 47 deletions
|
|
@ -91,10 +91,20 @@ get_unique_task_id()
|
||||||
task_decorator_factory()
|
task_decorator_factory()
|
||||||
|
|
||||||
|
|
||||||
from airflow.models import Param
|
from airflow.models import DagParam, Param, ParamsDict
|
||||||
|
|
||||||
# airflow.models
|
# airflow.models
|
||||||
Param()
|
Param()
|
||||||
|
DagParam()
|
||||||
|
ParamsDict()
|
||||||
|
|
||||||
|
|
||||||
|
from airflow.models.param import DagParam, Param, ParamsDict
|
||||||
|
|
||||||
|
# airflow.models.param
|
||||||
|
Param()
|
||||||
|
DagParam()
|
||||||
|
ParamsDict()
|
||||||
|
|
||||||
|
|
||||||
from airflow.sensors.base import (
|
from airflow.sensors.base import (
|
||||||
|
|
|
||||||
|
|
@ -262,9 +262,14 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
|
||||||
name: (*rest).to_string(),
|
name: (*rest).to_string(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
["airflow", "models", "Param"] => Replacement::Rename {
|
[
|
||||||
|
"airflow",
|
||||||
|
"models",
|
||||||
|
..,
|
||||||
|
rest @ ("Param" | "ParamsDict" | "DagParam"),
|
||||||
|
] => Replacement::SourceModuleMoved {
|
||||||
module: "airflow.sdk.definitions.param",
|
module: "airflow.sdk.definitions.param",
|
||||||
name: "Param",
|
name: (*rest).to_string(),
|
||||||
},
|
},
|
||||||
|
|
||||||
// airflow.models.baseoperator
|
// airflow.models.baseoperator
|
||||||
|
|
|
||||||
|
|
@ -737,79 +737,185 @@ AIR311 [*] `airflow.models.Param` is removed in Airflow 3.0; It still works in A
|
||||||
96 | # airflow.models
|
96 | # airflow.models
|
||||||
97 | Param()
|
97 | Param()
|
||||||
| ^^^^^
|
| ^^^^^
|
||||||
|
98 | DagParam()
|
||||||
|
99 | ParamsDict()
|
||||||
|
|
|
|
||||||
help: Use `Param` from `airflow.sdk.definitions.param` instead.
|
help: Use `Param` from `airflow.sdk.definitions.param` instead.
|
||||||
91 | task_decorator_factory()
|
91 | task_decorator_factory()
|
||||||
92 |
|
92 |
|
||||||
93 |
|
93 |
|
||||||
- from airflow.models import Param
|
- from airflow.models import DagParam, Param, ParamsDict
|
||||||
94 + from airflow.sdk.definitions.param import Param
|
94 + from airflow.models import DagParam, ParamsDict
|
||||||
95 |
|
95 + from airflow.sdk.definitions.param import Param
|
||||||
|
96 |
|
||||||
|
97 | # airflow.models
|
||||||
|
98 | Param()
|
||||||
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
|
AIR311 [*] `airflow.models.DagParam` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:98:1
|
||||||
|
|
|
||||||
96 | # airflow.models
|
96 | # airflow.models
|
||||||
97 | Param()
|
97 | Param()
|
||||||
|
98 | DagParam()
|
||||||
|
| ^^^^^^^^
|
||||||
|
99 | ParamsDict()
|
||||||
|
|
|
||||||
|
help: Use `DagParam` from `airflow.sdk.definitions.param` instead.
|
||||||
|
91 | task_decorator_factory()
|
||||||
|
92 |
|
||||||
|
93 |
|
||||||
|
- from airflow.models import DagParam, Param, ParamsDict
|
||||||
|
94 + from airflow.models import Param, ParamsDict
|
||||||
|
95 + from airflow.sdk.definitions.param import DagParam
|
||||||
|
96 |
|
||||||
|
97 | # airflow.models
|
||||||
|
98 | Param()
|
||||||
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
|
AIR311 [*] `airflow.models.ParamsDict` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:99:1
|
||||||
|
|
|
||||||
|
97 | Param()
|
||||||
|
98 | DagParam()
|
||||||
|
99 | ParamsDict()
|
||||||
|
| ^^^^^^^^^^
|
||||||
|
|
|
||||||
|
help: Use `ParamsDict` from `airflow.sdk.definitions.param` instead.
|
||||||
|
91 | task_decorator_factory()
|
||||||
|
92 |
|
||||||
|
93 |
|
||||||
|
- from airflow.models import DagParam, Param, ParamsDict
|
||||||
|
94 + from airflow.models import DagParam, Param
|
||||||
|
95 + from airflow.sdk.definitions.param import ParamsDict
|
||||||
|
96 |
|
||||||
|
97 | # airflow.models
|
||||||
|
98 | Param()
|
||||||
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
|
AIR311 [*] `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:105:1
|
||||||
|
|
|
||||||
|
104 | # airflow.models.param
|
||||||
|
105 | Param()
|
||||||
|
| ^^^^^
|
||||||
|
106 | DagParam()
|
||||||
|
107 | ParamsDict()
|
||||||
|
|
|
||||||
|
help: Use `Param` from `airflow.sdk.definitions.param` instead.
|
||||||
|
99 | ParamsDict()
|
||||||
|
100 |
|
||||||
|
101 |
|
||||||
|
- from airflow.models.param import DagParam, Param, ParamsDict
|
||||||
|
102 + from airflow.models.param import DagParam, ParamsDict
|
||||||
|
103 + from airflow.sdk.definitions.param import Param
|
||||||
|
104 |
|
||||||
|
105 | # airflow.models.param
|
||||||
|
106 | Param()
|
||||||
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
|
AIR311 [*] `airflow.models.param.DagParam` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:106:1
|
||||||
|
|
|
||||||
|
104 | # airflow.models.param
|
||||||
|
105 | Param()
|
||||||
|
106 | DagParam()
|
||||||
|
| ^^^^^^^^
|
||||||
|
107 | ParamsDict()
|
||||||
|
|
|
||||||
|
help: Use `DagParam` from `airflow.sdk.definitions.param` instead.
|
||||||
|
99 | ParamsDict()
|
||||||
|
100 |
|
||||||
|
101 |
|
||||||
|
- from airflow.models.param import DagParam, Param, ParamsDict
|
||||||
|
102 + from airflow.models.param import Param, ParamsDict
|
||||||
|
103 + from airflow.sdk.definitions.param import DagParam
|
||||||
|
104 |
|
||||||
|
105 | # airflow.models.param
|
||||||
|
106 | Param()
|
||||||
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
|
AIR311 [*] `airflow.models.param.ParamsDict` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:107:1
|
||||||
|
|
|
||||||
|
105 | Param()
|
||||||
|
106 | DagParam()
|
||||||
|
107 | ParamsDict()
|
||||||
|
| ^^^^^^^^^^
|
||||||
|
|
|
||||||
|
help: Use `ParamsDict` from `airflow.sdk.definitions.param` instead.
|
||||||
|
99 | ParamsDict()
|
||||||
|
100 |
|
||||||
|
101 |
|
||||||
|
- from airflow.models.param import DagParam, Param, ParamsDict
|
||||||
|
102 + from airflow.models.param import DagParam, Param
|
||||||
|
103 + from airflow.sdk.definitions.param import ParamsDict
|
||||||
|
104 |
|
||||||
|
105 | # airflow.models.param
|
||||||
|
106 | Param()
|
||||||
note: This is an unsafe fix and may change runtime behavior
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
AIR311 [*] `airflow.sensors.base.BaseSensorOperator` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
AIR311 [*] `airflow.sensors.base.BaseSensorOperator` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
--> AIR311_names.py:107:1
|
--> AIR311_names.py:117:1
|
||||||
|
|
|
|
||||||
106 | # airflow.sensors.base
|
116 | # airflow.sensors.base
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
| ^^^^^^^^^^^^^^^^^^
|
| ^^^^^^^^^^^^^^^^^^
|
||||||
108 | PokeReturnValue()
|
118 | PokeReturnValue()
|
||||||
109 | poke_mode_only()
|
119 | poke_mode_only()
|
||||||
|
|
|
|
||||||
help: Use `BaseSensorOperator` from `airflow.sdk` instead.
|
help: Use `BaseSensorOperator` from `airflow.sdk` instead.
|
||||||
98 |
|
108 |
|
||||||
99 |
|
109 |
|
||||||
100 | from airflow.sensors.base import (
|
110 | from airflow.sensors.base import (
|
||||||
- BaseSensorOperator,
|
- BaseSensorOperator,
|
||||||
101 | PokeReturnValue,
|
111 | PokeReturnValue,
|
||||||
102 | poke_mode_only,
|
112 | poke_mode_only,
|
||||||
103 | )
|
113 | )
|
||||||
104 + from airflow.sdk import BaseSensorOperator
|
114 + from airflow.sdk import BaseSensorOperator
|
||||||
105 |
|
115 |
|
||||||
106 | # airflow.sensors.base
|
116 | # airflow.sensors.base
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
note: This is an unsafe fix and may change runtime behavior
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
AIR311 [*] `airflow.sensors.base.PokeReturnValue` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
AIR311 [*] `airflow.sensors.base.PokeReturnValue` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
--> AIR311_names.py:108:1
|
--> AIR311_names.py:118:1
|
||||||
|
|
|
|
||||||
106 | # airflow.sensors.base
|
116 | # airflow.sensors.base
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
108 | PokeReturnValue()
|
118 | PokeReturnValue()
|
||||||
| ^^^^^^^^^^^^^^^
|
| ^^^^^^^^^^^^^^^
|
||||||
109 | poke_mode_only()
|
119 | poke_mode_only()
|
||||||
|
|
|
|
||||||
help: Use `PokeReturnValue` from `airflow.sdk` instead.
|
help: Use `PokeReturnValue` from `airflow.sdk` instead.
|
||||||
99 |
|
109 |
|
||||||
100 | from airflow.sensors.base import (
|
110 | from airflow.sensors.base import (
|
||||||
101 | BaseSensorOperator,
|
111 | BaseSensorOperator,
|
||||||
- PokeReturnValue,
|
- PokeReturnValue,
|
||||||
102 | poke_mode_only,
|
112 | poke_mode_only,
|
||||||
103 | )
|
113 | )
|
||||||
104 + from airflow.sdk import PokeReturnValue
|
114 + from airflow.sdk import PokeReturnValue
|
||||||
105 |
|
115 |
|
||||||
106 | # airflow.sensors.base
|
116 | # airflow.sensors.base
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
note: This is an unsafe fix and may change runtime behavior
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
AIR311 [*] `airflow.sensors.base.poke_mode_only` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
AIR311 [*] `airflow.sensors.base.poke_mode_only` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
--> AIR311_names.py:109:1
|
--> AIR311_names.py:119:1
|
||||||
|
|
|
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
108 | PokeReturnValue()
|
118 | PokeReturnValue()
|
||||||
109 | poke_mode_only()
|
119 | poke_mode_only()
|
||||||
| ^^^^^^^^^^^^^^
|
| ^^^^^^^^^^^^^^
|
||||||
|
|
|
|
||||||
help: Use `poke_mode_only` from `airflow.sdk` instead.
|
help: Use `poke_mode_only` from `airflow.sdk` instead.
|
||||||
100 | from airflow.sensors.base import (
|
110 | from airflow.sensors.base import (
|
||||||
101 | BaseSensorOperator,
|
111 | BaseSensorOperator,
|
||||||
102 | PokeReturnValue,
|
112 | PokeReturnValue,
|
||||||
- poke_mode_only,
|
- poke_mode_only,
|
||||||
103 | )
|
113 | )
|
||||||
104 + from airflow.sdk import poke_mode_only
|
114 + from airflow.sdk import poke_mode_only
|
||||||
105 |
|
115 |
|
||||||
106 | # airflow.sensors.base
|
116 | # airflow.sensors.base
|
||||||
107 | BaseSensorOperator()
|
117 | BaseSensorOperator()
|
||||||
note: This is an unsafe fix and may change runtime behavior
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue