mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 05:44:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[flake8-async] fix detection for large integer sleep durations in ASYNC116 rule (#18767)

Browse source 
Co-authored-by: Micha Reiser <micha@reiser.io>
This commit is contained in:
chiri 2025-06-19 12:37:20 +03:00 • committed by GitHub
parent 55a2ff91c7
commit 06da2c808f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 47 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ruff_linter/resources/test/fixtures/flake8_async/ASYNC116.py vendored
View file

@ -128,3 +128,11 @@ async def test_trio_async116_helpers():
await trio.sleep(seconds=86401) # ASYNC116 await trio.sleep(seconds=86401) # ASYNC116
await trio.sleep(delay=86401) # OK await trio.sleep(delay=86401) # OK
async def _():
import trio
from trio import sleep
await sleep(18446744073709551616)
await trio.sleep(99999999999999999999)

12
crates/ruff_linter/src/rules/flake8_async/rules/long_sleep_not_forever.rs
View file

@ -100,14 +100,10 @@ pub(crate) fn long_sleep_not_forever(checker: &Checker, call: &ExprCall) {
// TODO(ekohilas): Replace with Duration::from_days(1).as_secs(); when available. // TODO(ekohilas): Replace with Duration::from_days(1).as_secs(); when available.
let one_day_in_secs = 60 * 60 * 24; let one_day_in_secs = 60 * 60 * 24;
match value { match value {
Number::Int(int_value) => { Number::Int(int_value) => match int_value.as_u64() {
let Some(int_value) = int_value.as_u64() else { Some(int_value) if int_value <= one_day_in_secs => return,
return; _ => {} // The number is too large, and more than 24 hours
}; },
if int_value <= one_day_in_secs {
return;
}
}
Number::Float(float_value) => Number::Float(float_value) =>
{ {
#[expect(clippy::cast_precision_loss)] #[expect(clippy::cast_precision_loss)]

35
crates/ruff_linter/src/rules/flake8_async/snapshots/ruff_linter__rules__flake8_async__tests__ASYNC116_ASYNC116.py.snap
View file

@ -330,3 +330,38 @@ ASYNC116.py:129:11: ASYNC116 [*] `trio.sleep()` with >24 hour interval should us
129 |- await trio.sleep(seconds=86401) # ASYNC116 129 |- await trio.sleep(seconds=86401) # ASYNC116
129 |+ await trio.sleep_forever() # ASYNC116 129 |+ await trio.sleep_forever() # ASYNC116
130 130 | await trio.sleep(delay=86401) # OK 130 130 | await trio.sleep(delay=86401) # OK
131 131 |
132 132 |
ASYNC116.py:137:11: ASYNC116 [*] `trio.sleep()` with >24 hour interval should usually be `trio.sleep_forever()`
|
135 | from trio import sleep
136 |
137 | await sleep(18446744073709551616)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ASYNC116
138 | await trio.sleep(99999999999999999999)
|
= help: Replace with `trio.sleep_forever()`
ℹ Unsafe fix
134 134 | import trio
135 135 | from trio import sleep
136 136 |
137 |- await sleep(18446744073709551616)
137 |+ await trio.sleep_forever()
138 138 | await trio.sleep(99999999999999999999)
ASYNC116.py:138:11: ASYNC116 [*] `trio.sleep()` with >24 hour interval should usually be `trio.sleep_forever()`
|
137 | await sleep(18446744073709551616)
138 | await trio.sleep(99999999999999999999)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ASYNC116
|
= help: Replace with `trio.sleep_forever()`
ℹ Unsafe fix
135 135 | from trio import sleep
136 136 |
137 137 | await sleep(18446744073709551616)
138 |- await trio.sleep(99999999999999999999)
138 |+ await trio.sleep_forever()