mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 13:24:57 +00:00
[ty] initial support for slots=True
in dataclasses (#20278)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run
This commit is contained in:
parent
2467c4352e
commit
08fcf7e106
4 changed files with 85 additions and 1 deletions
|
@ -546,7 +546,29 @@ class A:
|
|||
|
||||
### `slots`
|
||||
|
||||
To do
|
||||
If a dataclass is defined with `slots=True`, the `__slots__` attribute is generated as a tuple. It
|
||||
is not present otherwise.
|
||||
|
||||
```py
|
||||
from dataclasses import dataclass
|
||||
from typing import Tuple
|
||||
|
||||
@dataclass
|
||||
class A:
|
||||
x: int
|
||||
y: int
|
||||
|
||||
# revealed: Unknown
|
||||
# error: [unresolved-attribute]
|
||||
reveal_type(A.__slots__)
|
||||
|
||||
@dataclass(slots=True)
|
||||
class B:
|
||||
x: int
|
||||
y: int
|
||||
|
||||
reveal_type(B.__slots__) # revealed: tuple[Literal["x"], Literal["y"]]
|
||||
```
|
||||
|
||||
### `weakref_slot`
|
||||
|
||||
|
|
|
@ -64,6 +64,30 @@ class AB( # error: [instance-layout-conflict]
|
|||
): ...
|
||||
```
|
||||
|
||||
## Synthesized `__slots__` from dataclasses
|
||||
|
||||
```py
|
||||
from dataclasses import dataclass
|
||||
|
||||
@dataclass(slots=True)
|
||||
class F: ...
|
||||
|
||||
@dataclass(slots=True)
|
||||
class G: ...
|
||||
|
||||
class H(F, G): ... # fine because both classes have empty `__slots__`
|
||||
|
||||
@dataclass(slots=True)
|
||||
class I:
|
||||
x: int
|
||||
|
||||
@dataclass(slots=True)
|
||||
class J:
|
||||
y: int
|
||||
|
||||
class K(I, J): ... # error: [instance-layout-conflict]
|
||||
```
|
||||
|
||||
## Invalid `__slots__` definitions
|
||||
|
||||
TODO: Emit diagnostics
|
||||
|
|
|
@ -165,6 +165,37 @@ static_assert(is_disjoint_from(D, B))
|
|||
static_assert(not is_disjoint_from(D, A))
|
||||
```
|
||||
|
||||
## Dataclasses
|
||||
|
||||
```py
|
||||
from dataclasses import dataclass
|
||||
from ty_extensions import is_disjoint_from, static_assert
|
||||
|
||||
@dataclass(slots=True)
|
||||
class F: ...
|
||||
|
||||
@dataclass(slots=True)
|
||||
class G: ...
|
||||
|
||||
@dataclass(slots=True)
|
||||
class I:
|
||||
x: int
|
||||
|
||||
@dataclass(slots=True)
|
||||
class J:
|
||||
y: int
|
||||
|
||||
# A dataclass with empty `__slots__` is not disjoint from another dataclass with `__slots__`
|
||||
static_assert(not is_disjoint_from(F, G))
|
||||
static_assert(not is_disjoint_from(F, I))
|
||||
static_assert(not is_disjoint_from(G, I))
|
||||
static_assert(not is_disjoint_from(F, J))
|
||||
static_assert(not is_disjoint_from(G, J))
|
||||
|
||||
# But two dataclasses with non-empty `__slots__` are disjoint
|
||||
static_assert(is_disjoint_from(I, J))
|
||||
```
|
||||
|
||||
## Tuple types
|
||||
|
||||
```py
|
||||
|
|
|
@ -2282,6 +2282,13 @@ impl<'db> ClassLiteral<'db> {
|
|||
}
|
||||
None
|
||||
}
|
||||
(CodeGeneratorKind::DataclassLike, "__slots__") => {
|
||||
has_dataclass_param(DataclassParams::SLOTS).then(|| {
|
||||
let fields = self.fields(db, specialization, field_policy);
|
||||
let slots = fields.keys().map(|name| Type::string_literal(db, name));
|
||||
Type::heterogeneous_tuple(db, slots)
|
||||
})
|
||||
}
|
||||
(CodeGeneratorKind::TypedDict, "__setitem__") => {
|
||||
let fields = self.fields(db, specialization, field_policy);
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue