mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-02 21:02:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Allow named expressions in __all__ assignments (#7673)

Browse source 
## Summary

This PR adds support for named expressions when analyzing `__all__`
assignments, as per https://github.com/astral-sh/ruff/issues/7672. It
also loosens the enforcement around assignments like: `__all__ =
list(some_other_expression)`. We shouldn't flag these as invalid, even
though we can't analyze the members, since we _know_ they evaluate to a
`list`.

Closes https://github.com/astral-sh/ruff/issues/7672.

## Test Plan

`cargo test`
This commit is contained in:
Charlie Marsh 2023-09-27 00:36:55 -04:00 • committed by GitHub
parent fbbc982c29
commit 0a8cad2550
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ruff_linter/resources/test/fixtures/pylint/invalid_all_format.py vendored
View file

@ -20,6 +20,8 @@ __all__ = foo.bar # [invalid-all-format]
__all__ = foo["bar"] # [invalid-all-format]
__all__ = (foo := bar) # [invalid-all-format]
__all__ = ["Hello"]
__all__ = ("Hello",)
@ -41,3 +43,7 @@ __all__ = __all__ + ["Hello"]
__all__ = __all__ + multiprocessing.__all__
__all__ = list[str](["Hello", "world"])
__all__ = list[str](foo())
__all__ = (foo := ["Hello", "world"])

22
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLE0605_invalid_all_format.py.snap
View file

@ -106,7 +106,27 @@ invalid_all_format.py:21:1: PLE0605 Invalid format for `__all__`, must be `tuple
21 | __all__ = foo["bar"] # [invalid-all-format]
| ^^^^^^^ PLE0605
22 |
23 | __all__ = ["Hello"]
23 | __all__ = (foo := bar) # [invalid-all-format]
|
invalid_all_format.py:23:1: PLE0605 Invalid format for `__all__`, must be `tuple` or `list`
|
21 | __all__ = foo["bar"] # [invalid-all-format]
22 |
23 | __all__ = (foo := bar) # [invalid-all-format]
| ^^^^^^^ PLE0605
24 |
25 | __all__ = ["Hello"]
|
invalid_all_format.py:23:12: PLE0605 Invalid format for `__all__`, must be `tuple` or `list`
|
21 | __all__ = foo["bar"] # [invalid-all-format]
22 |
23 | __all__ = (foo := bar) # [invalid-all-format]
| ^^^ PLE0605
24 |
25 | __all__ = ["Hello"]
|

12
crates/ruff_python_ast/src/all.rs
View file

@ -81,17 +81,21 @@ where
| Expr::Tuple(ast::ExprTuple { elts, .. }) => {
return (Some(elts), DunderAllFlags::empty());
}
Expr::ListComp(_) | Expr::SetComp(_) | Expr::GeneratorExp(_) => {
// Allow comprehensions, even though we can't statically analyze
// them.
_ => {
// We can't analyze other expressions, but they must be
// valid, since the `list` or `tuple` call will ultimately
// evaluate to a list or tuple.
return (None, DunderAllFlags::empty());
}
_ => {}
}
}
}
}
}
Expr::NamedExpr(ast::ExprNamedExpr { value, .. }) => {
// Allow, e.g., `__all__ += (value := ["A", "B"])`.
return extract_elts(value, is_builtin);
}
_ => {}
}
(None, DunderAllFlags::INVALID_FORMAT)