mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 05:14:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[ty] Enforce that an attribute on a class X must be callable in order to satisfy a member on a protocol P (#20142)

Browse source 
## Summary

Small, incremental progress towards checking the types of method
members.

## Test Plan

Added an mdtest
This commit is contained in:
Alex Waygood 2025-08-29 08:31:26 +01:00 • committed by GitHub
parent 4ca38b2974
commit 0d7ed32494
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ty_python_semantic/resources/mdtest/protocols.md
View file

@ -1704,7 +1704,11 @@ class NotSubtype:
def m(self, x: int) -> int: def m(self, x: int) -> int:
return 42 return 42
class DefinitelyNotSubtype:
m = None
static_assert(is_subtype_of(NominalSubtype, P)) static_assert(is_subtype_of(NominalSubtype, P))
static_assert(not is_subtype_of(DefinitelyNotSubtype, P))
# TODO: should pass # TODO: should pass
static_assert(not is_subtype_of(NotSubtype, P)) # error: [static-assert-error] static_assert(not is_subtype_of(NotSubtype, P)) # error: [static-assert-error]

3
crates/ty_python_semantic/src/types/protocol_class.rs
View file

@ -560,7 +560,8 @@ impl<'a, 'db> ProtocolMember<'a, 'db> {
db, db,
matches!( matches!(
other.to_meta_type(db).member(db, self.name).place, other.to_meta_type(db).member(db, self.name).place,
Place::Type(_, Boundness::Bound) Place::Type(ty, Boundness::Bound)
if ty.is_assignable_to(db, CallableType::single(db, Signature::dynamic(Type::any())))
), ),
), ),
// TODO: consider the types of the attribute on `other` for property members // TODO: consider the types of the attribute on `other` for property members