mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 05:44:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Followups to tuple constructor improvements in #18987 (#19000)

Browse source
This commit is contained in:
Alex Waygood 2025-06-27 22:09:14 +01:00 • committed by GitHub
parent caf3c916e8
commit 1297d6a9eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/ty_python_semantic/src/types.rs
View file

@ -4247,6 +4247,13 @@ impl<'db> Type<'db> {
Some(KnownClass::Tuple) => {
let object = Type::object(db);
// ```py
// class tuple:
// @overload
// def __new__(cls) -> tuple[()]: ...
// @overload
// def __new__(cls, iterable: Iterable[object]) -> tuple[object, ...]: ...
// ```
CallableBinding::from_overloads(
self,
[
@ -4308,6 +4315,13 @@ impl<'db> Type<'db> {
let instantiated = Type::instance(db, ClassType::from(alias));
let parameters = if alias.origin(db).is_known(db, KnownClass::Tuple) {
// ```py
// class tuple:
// @overload
// def __new__(cls: type[tuple[()]], iterable: tuple[()] = ()) -> tuple[()]: ...
// @overload
// def __new__[T](cls: type[tuple[T, ...]], iterable: tuple[T, ...]) -> tuple[T, ...]: ...
// ```
let spec = alias.specialization(db).tuple(db);
let mut parameter =
Parameter::positional_only(Some(Name::new_static("iterable")))

5
crates/ty_python_semantic/src/types/call/bind.rs
View file

@ -973,13 +973,16 @@ impl<'db> Bindings<'db> {
}
Some(KnownClass::Tuple) if overload_index == 1 => {
// `tuple(range(42))` => `tuple[int, ...]`
// BUT `tuple((1, 2))` => `tuple[Literal[1], Literal[2]]` rather than `tuple[Literal[1, 2], ...]`
if let [Some(argument)] = overload.parameter_types() {
let overridden_return =
argument.into_tuple().map(Type::Tuple).unwrap_or_else(|| {
// Some awkward special handling is required here because of the fact
// that calling `try_iterate()` on `Never` returns `Never`,
// but `tuple[Never, ...]` eagerly simplifies to `tuple[()]`,
// which will cause us to emit false positives if we index into the tuple
// which will cause us to emit false positives if we index into the tuple.
// Using `tuple[Unknown, ...]` avoids these false positives.
let specialization = if argument.is_never() {
Type::unknown()
} else {

2
crates/ty_python_semantic/src/types/class.rs
View file

@ -2427,7 +2427,7 @@ impl KnownClass {
| Self::Float
| Self::Enum
| Self::ABCMeta
| KnownClass::Iterable
| Self::Iterable
// Empty tuples are AlwaysFalse; non-empty tuples are AlwaysTrue
| Self::NamedTuple
// Evaluating `NotImplementedType` in a boolean context was deprecated in Python 3.9