From 12d2526edb611bbf3ebf1a996d7ca0937a22aa9c Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Fri, 6 Jan 2023 15:57:56 -0500 Subject: [PATCH] Require explicit opt-in for GitHub and Gitlab formats (#1697) --- README.md | 3 ++- src/settings/types.rs | 12 ------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 3a04e327b2..9625953a48 100644 --- a/README.md +++ b/README.md @@ -1327,8 +1327,9 @@ jobs: run: | python -m pip install --upgrade pip pip install ruff + # Include `--format=github` to enable automatic inline annotations. - name: Run Ruff - run: ruff . + run: ruff --format=github . ``` ## FAQ diff --git a/src/settings/types.rs b/src/settings/types.rs index 3379a3f179..56383b87c7 100644 --- a/src/settings/types.rs +++ b/src/settings/types.rs @@ -1,4 +1,3 @@ -use std::env; use std::hash::Hash; use std::ops::Deref; use std::path::{Path, PathBuf}; @@ -164,17 +163,6 @@ pub enum SerializationFormat { impl Default for SerializationFormat { fn default() -> Self { - if let Ok(github_actions) = env::var("GITHUB_ACTIONS") { - if github_actions == "true" { - return Self::Github; - } - } - - if let Ok(gitlab_ci) = env::var("GITLAB_CI") { - if gitlab_ci == "true" { - return Self::Gitlab; - } - } Self::Text } }