From 19c221a2d26d930e1c55276182255572d16dbd58 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Sun, 25 Jun 2023 21:57:52 -0400 Subject: [PATCH] Use matches for `os-error-alias` (#5361) --- .../src/rules/pyupgrade/rules/os_error_alias.rs | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/crates/ruff/src/rules/pyupgrade/rules/os_error_alias.rs b/crates/ruff/src/rules/pyupgrade/rules/os_error_alias.rs index 09f7821919..6739f5b680 100644 --- a/crates/ruff/src/rules/pyupgrade/rules/os_error_alias.rs +++ b/crates/ruff/src/rules/pyupgrade/rules/os_error_alias.rs @@ -54,21 +54,14 @@ impl AlwaysAutofixableViolation for OSErrorAlias { } } -const ALIASES: &[(&str, &str)] = &[ - ("", "EnvironmentError"), - ("", "IOError"), - ("", "WindowsError"), - ("mmap", "error"), - ("select", "error"), - ("socket", "error"), -]; - /// Return `true` if an [`Expr`] is an alias of `OSError`. fn is_alias(expr: &Expr, semantic: &SemanticModel) -> bool { semantic.resolve_call_path(expr).map_or(false, |call_path| { - ALIASES - .iter() - .any(|(module, member)| call_path.as_slice() == [*module, *member]) + matches!( + call_path.as_slice(), + ["", "EnvironmentError" | "IOError" | "WindowsError"] + | ["mmap" | "select" | "socket", "error"] + ) }) }