mirror of
https://github.com/astral-sh/ruff.git
synced 2025-07-14 16:45:10 +00:00
[red-knot] Empty tuple is always-falsy (#17213)
Some checks are pending
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
Some checks are pending
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary Fix assignability of `tuple[()]` to `AlwaysFalsy`. closes #17202 ## Test Plan Ran the property tests for a while
This commit is contained in:
parent
b3243b5e2a
commit
1a6a10b30f
2 changed files with 16 additions and 4 deletions
|
@ -183,7 +183,7 @@ static_assert(is_assignable_to(Meta, type[Unknown]))
|
||||||
## Tuple types
|
## Tuple types
|
||||||
|
|
||||||
```py
|
```py
|
||||||
from knot_extensions import static_assert, is_assignable_to
|
from knot_extensions import static_assert, is_assignable_to, AlwaysTruthy, AlwaysFalsy
|
||||||
from typing import Literal, Any
|
from typing import Literal, Any
|
||||||
|
|
||||||
static_assert(is_assignable_to(tuple[()], tuple[()]))
|
static_assert(is_assignable_to(tuple[()], tuple[()]))
|
||||||
|
@ -198,6 +198,14 @@ static_assert(is_assignable_to(tuple[()], tuple))
|
||||||
static_assert(is_assignable_to(tuple[int, str], tuple))
|
static_assert(is_assignable_to(tuple[int, str], tuple))
|
||||||
static_assert(is_assignable_to(tuple[Any], tuple))
|
static_assert(is_assignable_to(tuple[Any], tuple))
|
||||||
|
|
||||||
|
# TODO: It is not yet clear if we want the following two assertions to hold.
|
||||||
|
# See https://github.com/astral-sh/ruff/issues/15528 for more details. The
|
||||||
|
# short version is: We either need to special-case enforcement of the Liskov
|
||||||
|
# substitution principle on `__bool__` and `__len__` for tuple subclasses,
|
||||||
|
# or we need to negate these assertions.
|
||||||
|
static_assert(is_assignable_to(tuple[()], AlwaysFalsy))
|
||||||
|
static_assert(is_assignable_to(tuple[int], AlwaysTruthy))
|
||||||
|
|
||||||
static_assert(not is_assignable_to(tuple[()], tuple[int]))
|
static_assert(not is_assignable_to(tuple[()], tuple[int]))
|
||||||
static_assert(not is_assignable_to(tuple[int], tuple[str]))
|
static_assert(not is_assignable_to(tuple[int], tuple[str]))
|
||||||
static_assert(not is_assignable_to(tuple[int], tuple[int, str]))
|
static_assert(not is_assignable_to(tuple[int], tuple[int, str]))
|
||||||
|
|
|
@ -1071,9 +1071,13 @@ impl<'db> Type<'db> {
|
||||||
// This special case is required because the left-hand side tuple might be a
|
// This special case is required because the left-hand side tuple might be a
|
||||||
// gradual type, so we can not rely on subtyping. This allows us to assign e.g.
|
// gradual type, so we can not rely on subtyping. This allows us to assign e.g.
|
||||||
// `tuple[Any, int]` to `tuple`.
|
// `tuple[Any, int]` to `tuple`.
|
||||||
(Type::Tuple(_), _) => KnownClass::Tuple
|
(Type::Tuple(_), _)
|
||||||
|
if KnownClass::Tuple
|
||||||
.to_instance(db)
|
.to_instance(db)
|
||||||
.is_assignable_to(db, target),
|
.is_assignable_to(db, target) =>
|
||||||
|
{
|
||||||
|
true
|
||||||
|
}
|
||||||
|
|
||||||
// `type[Any]` is assignable to any `type[...]` type, because `type[Any]` can
|
// `type[Any]` is assignable to any `type[...]` type, because `type[Any]` can
|
||||||
// materialize to any `type[...]` type.
|
// materialize to any `type[...]` type.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue