mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-19 12:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[ty] Fix is_disjoint_from with @final classes (#21167)

Browse source 
## Summary

We currently perform a subtyping check instead of the intended subclass
check (and the subtyping check is confusingly named `is_subclass_of`).
This showed up in https://github.com/astral-sh/ruff/pull/21070.
This commit is contained in:
Ibraheem Ahmed 2025-10-31 10:50:54 -04:00 • committed by GitHub
parent 3179b05221
commit 1baf98aab3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 33 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/ty_python_semantic/resources/mdtest/type_properties/is_disjoint_from.md
View file

@ -87,6 +87,31 @@ static_assert(is_disjoint_from(memoryview, Foo))
static_assert(is_disjoint_from(type[memoryview], type[Foo]))
```
## Specialized `@final` types
```toml
[environment]
python-version = "3.12"
```
```py
from typing import final
from ty_extensions import static_assert, is_disjoint_from
@final
class Foo[T]:
def get(self) -> T:
raise NotImplementedError
class A: ...
class B: ...
static_assert(not is_disjoint_from(Foo[A], Foo[B]))
# TODO: `int` and `str` are disjoint bases, so these should be disjoint.
static_assert(not is_disjoint_from(Foo[int], Foo[str]))
```
## "Disjoint base" builtin types
Most other builtins can be subclassed and can even be used in multiple inheritance. However, builtin