mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-03 07:04:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Explicitly test assignability/subtyping between unions of nominal types and protocols with method members (#20557)

Browse source
This commit is contained in:
Alex Waygood 2025-09-25 10:21:29 +01:00 • committed by GitHub
parent b7d5dc98c1
commit 21be94ac33
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crates/ty_python_semantic/resources/mdtest/protocols.md
View file

@ -1769,6 +1769,9 @@ class P(Protocol):
class NominalSubtype: class NominalSubtype:
def m(self, y: int) -> None: ... def m(self, y: int) -> None: ...
class NominalSubtype2:
def m(self, *args: object) -> None: ...
class NotSubtype: class NotSubtype:
def m(self, x: int) -> int: def m(self, x: int) -> int:
return 42 return 42
@ -1785,18 +1788,24 @@ class DefinitelyNotSubtype:
m = None m = None
static_assert(is_subtype_of(NominalSubtype, P)) static_assert(is_subtype_of(NominalSubtype, P))
static_assert(is_subtype_of(NominalSubtype2, P))
static_assert(is_subtype_of(NominalSubtype | NominalSubtype2, P))
static_assert(not is_assignable_to(DefinitelyNotSubtype, P)) static_assert(not is_assignable_to(DefinitelyNotSubtype, P))
static_assert(not is_assignable_to(NotSubtype, P)) static_assert(not is_assignable_to(NotSubtype, P))
static_assert(not is_assignable_to(NominalSubtype | NotSubtype, P))
static_assert(not is_assignable_to(NominalSubtype2 | DefinitelyNotSubtype, P))
# `m` has the correct signature when accessed on instances of `NominalWithClassMethod`, # `m` has the correct signature when accessed on instances of `NominalWithClassMethod`,
# but not when accessed on the class object `NominalWithClassMethod` itself # but not when accessed on the class object `NominalWithClassMethod` itself
# #
# TODO: this should pass # TODO: these should pass
static_assert(not is_assignable_to(NominalWithClassMethod, P)) # error: [static-assert-error] static_assert(not is_assignable_to(NominalWithClassMethod, P)) # error: [static-assert-error]
static_assert(not is_assignable_to(NominalSubtype | NominalWithClassMethod, P)) # error: [static-assert-error]
# Conversely, `m` has the correct signature when accessed on the class object # Conversely, `m` has the correct signature when accessed on the class object
# `NominalWithStaticMethod`, but not when accessed on instances of `NominalWithStaticMethod` # `NominalWithStaticMethod`, but not when accessed on instances of `NominalWithStaticMethod`
static_assert(not is_assignable_to(NominalWithStaticMethod, P)) static_assert(not is_assignable_to(NominalWithStaticMethod, P))
static_assert(not is_assignable_to(NominalSubtype | NominalWithStaticMethod, P))
``` ```
A callable instance attribute is not sufficient for a type to satisfy a protocol with a method A callable instance attribute is not sufficient for a type to satisfy a protocol with a method
@ -2112,6 +2121,7 @@ static_assert(is_subtype_of(NClassMethodGood, PClassMethod)) # error: [static-a
static_assert(is_subtype_of(NClassMethodGood, PStaticMethod)) # error: [static-assert-error] static_assert(is_subtype_of(NClassMethodGood, PStaticMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NClassMethodBad, PClassMethod)) # error: [static-assert-error] static_assert(not is_assignable_to(NClassMethodBad, PClassMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NClassMethodBad, PStaticMethod)) # error: [static-assert-error] static_assert(not is_assignable_to(NClassMethodBad, PStaticMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NClassMethodGood | NClassMethodBad, PClassMethod)) # error: [static-assert-error]
static_assert(is_assignable_to(NStaticMethodGood, PClassMethod)) static_assert(is_assignable_to(NStaticMethodGood, PClassMethod))
static_assert(is_assignable_to(NStaticMethodGood, PStaticMethod)) static_assert(is_assignable_to(NStaticMethodGood, PStaticMethod))
@ -2120,6 +2130,7 @@ static_assert(is_subtype_of(NStaticMethodGood, PClassMethod)) # error: [static-
static_assert(is_subtype_of(NStaticMethodGood, PStaticMethod)) # error: [static-assert-error] static_assert(is_subtype_of(NStaticMethodGood, PStaticMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NStaticMethodBad, PClassMethod)) # error: [static-assert-error] static_assert(not is_assignable_to(NStaticMethodBad, PClassMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NStaticMethodBad, PStaticMethod)) # error: [static-assert-error] static_assert(not is_assignable_to(NStaticMethodBad, PStaticMethod)) # error: [static-assert-error]
static_assert(not is_assignable_to(NStaticMethodGood | NStaticMethodBad, PStaticMethod)) # error: [static-assert-error]
``` ```
## Equivalence of protocols with method or property members ## Equivalence of protocols with method or property members